Repository navigation
test(evaluate): drop page timers from the overwritten Promise test - #43439
Merged
Merged
Conversation
The assertions added in #43436 resolved the promise and set the flag with setTimeout in the page. The frozen-clock project pauses page timers, so page.evaluateHandle never returned and the test timed out on the frozen-time-library-chromium-linux bot on every commit since. Resolve the promise from a microtask and set the flag before polling instead. Against the pre-#43436 utility script the test still fails on Firefox and WebKit, where jsonValue() does not return 42. Failing runs: https://github.com/microsoft/playwright/actions/runs/38803229595 https://github.com/microsoft/playwright/actions/runs/38803289664 https://github.com/microsoft/playwright/actions/runs/38808174514
Contributor
Test results for "MCP"1 failed 5153 passed, 614 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky23557 passed, 710 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failure. 🟡 The failure is likely unrelated to this PR, but it is not a confirmed flake
DetailsUncertain
Triaged by the Playwright bot - agent run |
Yury Semikhatsky (yury-s)
marked this pull request as ready for review
October 15, 2026 22:45
Pavel Feldman (pavelfeldman)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertions added in #43436 resolved the promise and set the flag with
setTimeoutin the page. The frozen-clock project (PW_CLOCK=frozen) pauses page timers, sopage.evaluateHandlenever returned and "should work with overwritten Promise" timed out on thefrozen-time-library-chromium-linuxbot on every commit since:Resolve the promise from a microtask and set the flag before polling instead. Checked that against the pre-#43436 utility script the test still fails on Firefox and WebKit (
jsonValue()is not 42), and that the whole spec passes underPW_CLOCK=frozenand on all three browsers.