RFC: Refactor dev dependencies lists and remove tox - #741
Draft
zliang-akamai wants to merge 1 commit into
Draft
Conversation
zliang-akamai
requested review from
ezilber-akamai and
mawilk90
and removed request for
a team
September 9, 2026 21:24
zliang-akamai
requested review from
a team,
lgarber-akamai and
psnoch-akamai
and
a lite review from Copilot
and removed request for
a team
September 9, 2026 21:25
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency/execution changes are internally consistent across pyproject.toml, README, and CI, and tox references appear fully removed from the repo’s workflow.
Pull request overview
This PR removes the repository’s tox-based test runner and consolidates test/dev dependency management into pyproject.toml extras, aligning local workflows with CI by running unit tests directly via pytest through make test-unit.
Changes:
- Removed
tox.iniand updated documentation to run unit tests viapip install ".[unit-test]"+make test-unit. - Refactored
pyproject.tomloptional dependency groups intotest-shared,unit-test,int-test,lint,doc, anddev. - Updated GitHub Actions CI to install the new unit-test extra and run
make test-unitinstead of invoking tox.
File summaries
| File | Description |
|---|---|
| tox.ini | Removes tox configuration entirely. |
| README.rst | Updates contributor test instructions to use .[unit-test] and make test-unit. |
| pyproject.toml | Reorganizes optional dependency extras to avoid duplicating test deps across tools. |
| AGENTS.md | Removes tox.ini-related guidance now that tox is gone. |
| .github/workflows/ci.yml | Switches CI test execution from tox to make test-unit with the new extra. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
psnoch-akamai
marked this pull request as draft
September 10, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tox config is outdated (containing EOL Python versions, lacking newer Python versions), and it's unnecessary to run the unit tests as we already directly use
pytestinmake test-unit.Removal of
toxcan unify things so we don't have to define unit tests dependencies in two places (pyproject.tomlandtox.ini), and we will get a more consistent behavior between CI and localmake test-unitbecause they both runpytestdirectly.