TPT-4671: Generate SSH keys in process for integration tests - #742
Draft
zliang-akamai wants to merge 2 commits into
Draft
TPT-4671: Generate SSH keys in process for integration tests#742zliang-akamai wants to merge 2 commits into
zliang-akamai wants to merge 2 commits into
Conversation
Drop the ssh-keygen subprocess so the suite does not need OpenSSH on the host. Add cryptography as an int-test extra.
zliang-akamai
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Integration tests currently create SSH keys by shelling out to
ssh-keygen, which fails on hosts that do not have OpenSSH installed. Generate Ed25519 keys in process with cryptography so the suite no longer depends on that host binary.✔️ How to Test