Repository navigation
feat: add overrideAffected to flag metadata - #45
Merged
Merged
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
kinyoklion
marked this pull request as ready for review
November 12, 2026 23:20
keelerm84
approved these changes
Nov 16, 2026
3 tasks done
This was referenced Nov 16, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Nov 18, 2026
🤖 I have created a release *beep* *boop* --- ## [0.4.0](0.3.1...0.4.0) (2026-11-17) ### Features * add overrideAffected to flag metadata ([#45](#45)) ([8ae500c](8ae500c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Describe the solution you've provided
ResolutionDetailsConverternow setsoverrideAffected: truein flag metadata whenEvaluationReason#override_affectedis true, and omits it otherwise (same asinExperiment, and as js-core'stranslateResult.ts). Thelaunchdarkly-server-sdkdependency moves from~> 8.19to~> 8.20, the first release withoverride_affected. The README flag-metadata table and feature matrix list the new key.Tests cover override-affected true, false, unmarked reasons and an override-affected error evaluation.
bundle exec rspec(78 examples, 0 failures) andrubocoppass locally on Ruby 3.4.7.Describe alternatives you've considered
A
respond_to?(:override_affected)guard that keeps the 8.19 floor (the approach in #44). Raising the floor is simpler, stays within the 8.x major and avoids a dead code path.Additional context
None.
OpenFeature Maintainer opened this PR for Ryan
Implemented in session Add overrideAffected metadata to Ruby provider
Review with Devin · Open in Devin Desktop
SDK-3580
Note
Overview
Adds OpenFeature flag metadata support for LaunchDarkly override evaluations by surfacing
overrideAffected: truewhenEvaluationReason#override_affectedis set, and omitting the key otherwise (same pattern asinExperiment).ResolutionDetailsConvertergains theoverrideAffectedmetadata key; thelaunchdarkly-server-sdkruntime floor moves from ~> 8.19 to ~> 8.20 sooverride_affectedis always available. README feature matrix and flag-metadata table document the new key; specs cover positive, false, absent, and error-with-override cases.Reviewed by Cursor Bugbot for commit 461bd56. Bugbot is set up for automated code reviews on this repo. Configure here.