Skip to content

fix: Reject mixed-type private attribute lists - #48

Open
kinyoklion wants to merge 2 commits into
mainfrom
devin/1794846300-ruby-private-attribute-validation
Open

kinyoklion wants to merge 2 commits into
mainfrom
devin/1794846300-ruby-private-attribute-validation

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Accepted OFP requirements 2.4.4–2.4.5.1.

Describe the solution you've provided

Reject the whole privateAttributes reserved attribute with an error if any list entry is not a string, rather than silently retaining a valid subset. Valid/empty lists retain their existing behavior.

Describe alternatives you've considered

Filtering individual entries conflicts with OFP 2.4.5, which requires leaving the corresponding context property unset for an invalid type.

Additional context

A malformed list such as ["email", true] now sets no private attributes; applications must supply a valid all-string list to mark attributes private. The original validation/tests were written by Matthew M. Keeler; this fix is by Devin for Ryan. Updated cleanly with main after #45 merged (8ae500c). Local Ruby 3.4: 79 examples pass; RuboCop clean. CI passes on Linux Ruby 3.4, JRuby 10.0 and Windows Ruby 3.4; Devin Review found no issues. Left as a draft per Ryan's account setting.


OpenFeature Maintainer opened this PR for Ryan
Implemented in session Audit openfeature-ruby-server provider this week
Review with Devin · Open in Devin Desktop


SDK-3721


Note

Overview
privateAttributes validation is now all-or-nothing in EvaluationContextConverter: if any list element is not a string, the converter logs an error and does not set _meta.privateAttributes on the LD context (previously valid strings in a mixed list were still applied).

Behavior for all-string arrays and empty arrays is unchanged. A spec asserts that ["email", true] yields an empty private_attributes and the existing error message, aligning with OFP behavior that invalid reserved attributes should be left unset rather than partially honored.

Reviewed by Cursor Bugbot for commit 18d0bf1. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@kinyoklion
kinyoklion marked this pull request as ready for review November 16, 2026 22:20
@kinyoklion
kinyoklion requested a review from a team as a code owner November 16, 2026 22:20

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated risk review (dry run): Medium

This PR would not be automatically approved. Human approval required.

Why: context_converter.rb changes existing privateAttributes handling so mixed-type lists unset all private markings instead of keeping valid strings; that is a privacy-related SDK behavior change, even with the new test in context_converter_spec.rb.

If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

@cursor cursor Bot added the risk:medium label Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant