Repository navigation
Regenerate CompatibilitySuppressions.xml after the Polyfill 11.4.5 bump [patch] - #73
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
…mp [patch] Polyfill 11.4.5 changed which shim members are emitted per target framework, so pack failed package validation on main: 8 CP0014 and 1 CP0015 on the embedded ExperimentalAttribute and DefaultInterpolatedStringHandler shims, and most of the 154 existing suppressions (CP0001, CP0002, CP0008, CP0014, CP0015, CP0016 across the older TFM pairs) were reported as unnecessary. That is why 1.0.49 is still the latest release and the #70 base-name ordering fix never shipped. Regenerated with -p:ApiCompatGenerateSuppressionFile=true, leaving 11 entries (10 CP0014, 1 CP0015). All are on Polyfill shim types, none on Sorting's own API. Fixes #72 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW2yWAiM4Xm9iHUvALj
|
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
What changed
Regenerated
Sorting/CompatibilitySuppressions.xmlwithdotnet pack -c Release -p:ApiCompatGenerateSuppressionFile=true. This is the same fix as the other Polyfill 11.4.5 repos (ImGuiProvider#84, RunCommand#127, Invoker#89).ExperimentalAttributeandDefaultInterpolatedStringHandlershims, none on Sorting's own API.Verification (SDK 10.0.403, Linux)
dotnet pack Sorting/Sorting.csproj -c Releaseexits 1, with 8 CP0014, 1 CP0015, "Unnecessary suppressions found" and "API breaking changes found".ktsu.Sorting.1.0.50.nupkgwith no errors.dotnet testpasses: 27 of 27.Not verified: the Windows release runner. The next main run should publish 1.0.50 or later, with the #70 fix.
Generated by Claude Code