Repository navigation
Regenerate CompatibilitySuppressions.xml after the Polyfill 11.4.5 bump [patch] - #129
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
…mp [patch] Polyfill 11.4.5 changed which shim members are emitted per target framework, so pack failed package validation on main with 151 errors (80 CP0016, 56 CP0001, 6 CP0014, 4 CP0015, 3 CP0002, 2 CP0008), all on polyfilled BCL types. That is why 1.4.1 is still the latest release and the #117, #118 and #119 fixes never shipped. Regenerated with -p:ApiCompatGenerateSuppressionFile=true, which leaves 11 entries (10 CP0014, 1 CP0015) instead of 153. All of them are on Polyfill shim types and none on FuzzySearch's own API. Fixes #128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW6Hi85XX4Q7wr44mWe
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After the Polyfill 11.4.5 bump, which changed which shim members are emitted for each target framework,
dotnet packfails package validation onmain. Reproduced locally with 151 errors:Every one is on a polyfilled BCL type. This is why 1.4.1 is still the latest release, and why #117, #118 and #119 never shipped.
Change
FuzzySearch/CompatibilitySuppressions.xmlwith-p:ApiCompatGenerateSuppressionFile=true.System.*; none suppress anything in FuzzySearch's own API.Verification
dotnet pack FuzzySearch -c Releasefails with the errors above.bin/obj: pack succeeds and writesktsu.FuzzySearch.1.4.2.nupkg.dotnet test: 116 passed, 0 failed.Once this merges, the next
mainrun should publish 1.4.2, which meets the issue's second acceptance criterion.Fixes #128
Generated by Claude Code