Repository navigation
Add CompatibilitySuppressions.xml for the Polyfill 11.4.5 shim drift [patch] - #91
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
…[patch] Polyfill 11.4.5 changed the nullable and compiler-generated attributes on its embedded ExperimentalAttribute and DefaultInterpolatedStringHandler shims, so package validation reported CP0014/CP0015 between the net8.0, net9.0 and net10.0 assets and every pack on main has failed since 2026-10-13. The diagnostics are on Polyfill's internal shims, not on DelegateTransform's API. Generated with `dotnet pack -c Release -p:ApiCompatGenerateSuppressionFile=true` on SDK 10.0.403. The 11 entries match the 11 diagnostics in the failing CI run 41251357978. Fixes #90 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4kJTwmbNJbKX5P18J
|
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
What
This PR adds
DelegateTransform/CompatibilitySuppressions.xmlwith 11 suppressions (CP0014 ×10, CP0015 ×1). Polyfill 11.4.5 changed nullable and compiler-generated attributes on its embeddedExperimentalAttributeandDefaultInterpolatedStringHandlershims. Package validation therefore fails between thenet8.0,net9.0andnet10.0assets, and every pack onmainhas failed since 2026-10-13. None of the suppressed diagnostics touch DelegateTransform's own API.How it was made
dotnet pack DelegateTransform/DelegateTransform.csproj -c Release -p:ApiCompatGenerateSuppressionFile=trueon SDK 10.0.403, the same SDK as the Windows CI runner.Verification
main, without the file:dotnet pack -c Releasefails with the same 11 CP0014/CP0015 errors as CI run 41251357978. That run logs14 Error(s): the 11 diagnostics plus 3 summary lines. The issue's "30 × CP0014 and 3 × CP0015" counts each line twice in the log.dotnet pack -c Releasesucceeds, with validation on and generation off.dotnet test: 13/13 passed.The SDK rewrites
.gitignoreduring every build (the UnityPackages/exception). That change is unrelated, so this PR leaves it out.Generated by Claude Code