Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5783 +/- ##
=======================================
Coverage 76.13% 76.13%
=======================================
Files 528 528
Lines 19579 19579
Branches 3829 3829
=======================================
Hits 14906 14906
Misses 3791 3791
Partials 882 882 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The app samples only check that they compile, but their Release builds trim, AOT-compile and package each app. In the macOS leg that's about 13.7 of the Build step's 28.3 task-minutes, and it's the whole tail of the step once the Cocoa SDK comes from the cache. On Windows, the MAUI sample's Android build is the last thing the Build step finishes. The Android, iOS, Mac Catalyst, macOS and MAUI samples now build in a separate job that starts with the .NET legs. It builds all of them on macOS, and the MAUI sample on Windows, which is the only build of its Windows target. The legs' solution filters no longer include them, and Sentry-CI-Build-Samples-macOS.slnf lists them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ric-oliv
force-pushed
the
ci/build-app-samples-in-parallel
branch
from
October 23, 2026 13:57
ce3f0f3 to
15d6751
Compare
ric-oliv
marked this pull request as ready for review
October 23, 2026 17:57
This was referenced Oct 23, 2026
The linux-x64 leg built the Android targets of the Android and MAUI samples on a Linux host. Moving the app samples out of the legs dropped that, so the samples job gets a linux-x64 entry with a generated filter for those two samples. The samples job's Cocoa SDK steps now match the macOS leg's: release branches build it from source, and a cache miss gets saved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
The platform solution filters no longer include the app samples, so msbuild.exe stopped building any Android or Windows app. The MSBuild job now builds the MAUI sample after the solution filter. It took 180 to 211 seconds on three runs, and the job still ended about 10 minutes before the slowest check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app samples are compile checks. Nothing in CI consumes their output, and they reference the SDK projects directly. But CI builds them in Release, so each one is trimmed, AOT-compiled and packaged. In a macOS build with the Cocoa SDK from the cache, version7 run 39648348730, they're about 13.7 of the 28.3 task-minutes in the Build step and its last 8 minutes, with two of the three MSBuild nodes mostly idle. On Windows, the MAUI sample's Android build is the last thing in the Build step.
This PR moves them into a
Samplesjob that runs next to the.NETlegs instead of inside them:Samples (macos)builds the Android, iOS, Mac Catalyst, macOS and MAUI samples from the newSentry-CI-Build-Samples-macOS.slnf, with the Cocoa SDK cache from ci: cache the Cocoa SDK build #5781.Samples (win-x64)builds the MAUI sample, because it's the only build of its Windows target.Samples (linux-x64)builds the Android and MAUI samples from the newSentry-CI-Build-Samples-Linux.slnf, so their Android targets still build on a Linux host, as they did in the linux-x64 leg.generate-solution-filters-config.yaml. The console and ASP.NET samples stay in the legs, because they cost seconds and build on every OS.AGENTS.mdsays which filters build the app samples now.The samples still build in Release, and a failure still fails the workflow. The only change in coverage is that win-arm64 no longer builds the MAUI sample. The win-x64 entry builds the same targets.
The first version of this PR also stopped building the Android and MAUI samples on Linux, which an independent review caught. The
linux-x64entry brings that back, and I'll add its first run's numbers here.Measured on two runs of this PR, against the median of 7
mainruns from October 22 and 23:mainBuildstepBuildBuildBuildSamples (macos)jobSamples (win-x64)jobThe MSBuild job builds the MAUI sample again
With the app samples out of the platform solution filters, msbuild.exe stopped building any Android or Windows app. So the MSBuild job now builds the MAUI sample right after the solution filter. On three runs on top of the other CI changes, that step took 180 to 211 seconds, and the job still ended about 10 minutes before the slowest check.
#skip-changelog