Repository navigation
ci: cache the Cocoa SDK build - #5781
Merged
Merged
Conversation
The macOS build job and the iOS device tests build the Cocoa SDK from the sentry-cocoa submodule on every run. In the macOS Build step on main, that takes 12.2 of 23.7 minutes on one MSBuild node, and the other two nodes go idle waiting for the Cocoa bindings. version7 caches it since #5746, and this brings the same steps to main. The key covers the selected Xcode, build-sentry-cocoa.sh, sentry-cocoa.xcconfig and the submodule commit. Pushes to main save the cache, so pull requests restore it from there. Release branches still build it from source, because it ships in the Sentry.Bindings.Cocoa package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
==========================================
+ Coverage 76.12% 76.13% +0.01%
==========================================
Files 528 528
Lines 19579 19579
Branches 3829 3829
==========================================
+ Hits 14904 14906 +2
+ Misses 3792 3791 -1
+ Partials 883 882 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS build job builds the Cocoa SDK from the sentry-cocoa submodule on every run. In the binlog of run 39921957359, that's 12.2 of the 23.7 minutes in the Build step, on one of the three MSBuild nodes. The other two run out of work by minute 10 and wait for the Cocoa bindings. The iOS device tests build it too.
version7 has cached it since #5746, and this PR brings the same steps to
main:cocoa-cache-keyaction keyed on the selected Xcode,build-sentry-cocoa.sh,sentry-cocoa.xcconfigand the submodule commit.Sentry.Bindings.Cocoapackage.I left out the warm-up workflow, because pushes to
mainalready runbuild.ymland save the cache for every PR. I also left out thepin-xcodeaction, which only the warm-up uses, and the verify-api change, which I'll send separately. The Cocoa steps matchversion7line for line, so the next merge between the branches stays clean.Measured against the median of 7
mainruns from October 22 and 23:mainBuild iOS Test AppBuildstepBuildstep gains less than the 12 minutes the Cocoa build took, because the rest of the step keeps all three cores busy and the app samples become its tail. ci: build the app samples in their own job #5783 moves those samples into their own job, and with both changes the step took 6.6 minutes.#skip-changelog