Repository navigation
fix(transcript): make a skipped word's restore control reachable - #1035
Merged
Merged
Conversation
The hover chips of the word stream (restore a cut word, revert a correction, delete an inserted word) were inserted into the text flow while the word was hovered. After a word ending its line the chip did not fit and wrapped to the start of the next line, so the pointer could only reach it by leaving the word, which took it away. It also reflowed the paragraph on every hover. The chip is now laid over the stream just past the word, with the gap as its own padding so the way onto it never leaves the word. The cut word's restore button now goes through WordChipButton instead of a copy of it. Refs #1012
The undo shortcut treated every contentEditable as a text field and left it to the browser's text undo. The transcript is contentEditable only to carry a caret: its edits are document writes (Backspace is a trim) that the browser's history never sees, so Ctrl+Z there, and Cmd+Z through the Edit menu on macOS, did nothing at all. A block marked data-document-undo now gets the document undo. The word editor and other fields inside it keep the browser's text undo. Refs #1012
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe transcript editor now shows a reachable restore control when hovering over a skipped word. Ctrl+Z and the exposed undo handler can remove the word’s skip marker through document-level undo. ChangesTranscript word restoration
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This change makes the restore control for skipped transcript words reachable and routes Ctrl/Cmd+Z in the transcript to document undo. No actionable merge-blocking risk was found. Testing with a real OS pointer on macOS has not been done. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #1012
Type of change
Release impact
Desktop impact
Testing
TranscriptPane.restore.test.tsx: hover, the move onto the chip, the restore, and Ctrl+Z by keydown and by the Edit menu. 3 of 4 fail onmain.🤖 Generated with Claude Code