Repository navigation
feat(review): run the whole code review from one caller job - #139
Merged
Merged
Conversation
The AI review workflow now also re-evaluates the review gate on pull_request_target and review events, so a project calls one workflow with secrets: inherit and no conditions of its own. plugin and skill_path are taken from the marketplace manifest when empty, and the reviewer falls back to the PROJECT_REVIEWER variable. The nightly and on-demand builds send the feature review message themselves when SLACK_WEBHOOK_FEATURE_REVIEW is passed, mentioning the reviewer's Slack ID from the SLACK_USER_IDS variable. The separate review gate and feature review notify workflows are removed: both are covered by the workflows above. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects now call one workflow for the code review and pass the Slack webhook to their build workflows instead of adding their own jobs and conditions.
universal-cloud-ai-pr-reviewreview-gatestatus onpull_request_targetandpull_request_reviewevents (the formeruniversal-cloud-review-gate). Each job picks its own events, so the caller needs noif:. With a single caller job, no skipped check run is ever namedreview-gate.CLAUDE_CODE_OAUTH_TOKENis optional, sosecrets: inheritworks for bot-authored PRs too. The review step still fails without it.pluginandskill_pathare optional and are read from the marketplace manifest (skills/<skill-name>in the plugin's directory).reviewerfalls back to the caller'sPROJECT_REVIEWERvariable.ios-selfhosted-nightly-build/ios-selfhosted-on-demand-buildSLACK_WEBHOOK_FEATURE_REVIEW. With it, anotify_feature_reviewjob announces thefeature-completePRs in the build (the formeruniversal-cloud-feature-review-notify).PROJECT_REVIEWERlogin's Slack ID from theSLACK_USER_IDSvariable ({"login": "U0123456"}).Removed:
universal-cloud-review-gate.ymlanduniversal-cloud-feature-review-notify.yml. Both were new in 2.8.0, and their only callers move to the workflows above.The caller now looks like this:
Tested from this branch on a consumer PR. The skill was resolved from the manifest, the review ran without permission denials, and the comment and gate were posted. actionlint and the bats suites pass.