Skip to content

feat(review): run the whole code review from one caller job - #139

Merged
jmarek41 merged 2 commits into
mainfrom
feat/single-code-review-workflow
Oct 27, 2026
Merged

jmarek41 merged 2 commits into
mainfrom
feat/single-code-review-workflow

Conversation

@jmarek41

@jmarek41 jmarek41 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Projects now call one workflow for the code review and pass the Slack webhook to their build workflows instead of adding their own jobs and conditions.

universal-cloud-ai-pr-review

  • Also re-evaluates the review-gate status on pull_request_target and pull_request_review events (the former universal-cloud-review-gate). Each job picks its own events, so the caller needs no if:. With a single caller job, no skipped check run is ever named review-gate.
  • CLAUDE_CODE_OAUTH_TOKEN is optional, so secrets: inherit works for bot-authored PRs too. The review step still fails without it.
  • plugin and skill_path are optional and are read from the marketplace manifest (skills/<skill-name> in the plugin's directory).
  • reviewer falls back to the caller's PROJECT_REVIEWER variable.

ios-selfhosted-nightly-build / ios-selfhosted-on-demand-build

  • New optional secret SLACK_WEBHOOK_FEATURE_REVIEW. With it, a notify_feature_review job announces the feature-complete PRs in the build (the former universal-cloud-feature-review-notify).
  • The message mentions the PROJECT_REVIEWER login's Slack ID from the SLACK_USER_IDS variable ({"login": "U0123456"}).

Removed: universal-cloud-review-gate.yml and universal-cloud-feature-review-notify.yml. Both were new in 2.8.0, and their only callers move to the workflows above.

The caller now looks like this:

jobs:
  review:
    uses: futuredapp/.github/.github/workflows/universal-cloud-ai-pr-review.yml@<version>
    with:
      marketplace_repository: <owner>/<marketplace>
      skill: <plugin>:<skill>
    secrets: inherit

Tested from this branch on a consumer PR. The skill was resolved from the manifest, the review ran without permission denials, and the comment and gate were posted. actionlint and the bats suites pass.

jmarek41 and others added 2 commits October 27, 2026 14:03
The AI review workflow now also re-evaluates the review gate on
pull_request_target and review events, so a project calls one workflow
with secrets: inherit and no conditions of its own. plugin and
skill_path are taken from the marketplace manifest when empty, and the
reviewer falls back to the PROJECT_REVIEWER variable.

The nightly and on-demand builds send the feature review message
themselves when SLACK_WEBHOOK_FEATURE_REVIEW is passed, mentioning the
reviewer's Slack ID from the SLACK_USER_IDS variable.

The separate review gate and feature review notify workflows are
removed: both are covered by the workflows above.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@jmarek41
jmarek41 merged commit 2198279 into main Oct 27, 2026
2 checks passed
@jmarek41
jmarek41 deleted the feat/single-code-review-workflow branch October 27, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant