Skip to content

Switch template to AI PR review with review gate - #57

Open
jmarek41 wants to merge 12 commits into
mainfrom
housekeep/ai-pr-review
Open

jmarek41 wants to merge 12 commits into
mainfrom
housekeep/ai-pr-review

Conversation

@jmarek41

@jmarek41 jmarek41 commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Summary

The template adopts the new iOS code review process: an AI review bot on every push to a PR into develop, human approval only for red zones and needs-human, evidence in every PR, and feature review in the app after nightly and on-demand builds.

Changes

  • .github/workflows/code-review.yml: one job calling the shared universal-cloud-ai-pr-review with secrets: inherit. The shared workflow runs the review and the review-gate status on the right events and takes the reviewer from PROJECT_REVIEWER.
  • nightly-build.yml, on-demand-build.yml: pass SLACK_WEBHOOK_FEATURE_REVIEW. The shared build workflows post PRs labeled feature-complete to Slack and mention the reviewer through the SLACK_USER_IDS org variable.
  • .github/pull_request_template.md: Summary, Evidence, What to try.
  • AGENTS.md: PR rule, ## Red zones section (read from the base branch), /ios-review row.
  • CODEOWNERS removed: without a mandatory approval it only auto-requested the whole iOS team on every PR.
  • Shared workflow refs bumped from 2.5.0. Code review and the two build workflows are on main until the next shared release (feat(review): run the whole code review from one caller job .github#139).

Evidence

actionlint is clean. The same code-review.yml runs on a consumer project.

Notes

Merge after the next .github release, with these refs moved from main to that tag. Per project: the repository variable PROJECT_REVIEWER and the ruleset command from the handbook (Engineering-Handbook#121).

🤖 Generated with Claude Code

jmarek41 and others added 7 commits October 14, 2026 10:49
Adds the AI review and review gate callers, a PR template with Evidence
and What to try, and the feature review Slack ping in the nightly build.
CODEOWNERS is removed: with no mandatory approval it only auto-requested
the whole team on every PR; the needs-human reviewer comes from the
PROJECT_REVIEWER repository variable instead. Shared workflow refs move
to 2.8.0, the release that ships these workflows.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ai-review.yml and review-gate.yml become code-review.yml: the AI review
runs on every push of a ready PR, the gate on pull_request_target and
review events. Nightly and on-demand builds keep their original
permissions; the Slack ping is a separate feature-review job.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@jmarek41
jmarek41 marked this pull request as ready for review October 21, 2026 14:58
@jmarek41
jmarek41 requested a review from a team as a code owner October 21, 2026 14:58
@jmarek41
jmarek41 requested a review from ssestak October 21, 2026 15:00
@jmarek41 jmarek41 mentioned this pull request Oct 23, 2026
jmarek41 and others added 5 commits October 26, 2026 19:39
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A skipped job leaves a check run named after it, and a required check
named review-gate would accept that skipped run.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The shared workflow picks the events for the review and the gate and
takes the reviewer from PROJECT_REVIEWER; the build workflows send the
feature review message themselves. Refs are on main until the next
shared workflows release.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant