Skip to content

Add V2 split collision recipes for Isaac assets - #143

Merged
kou merged 2 commits into
enactic:mainfrom
stevenaya:feat/isaac-collision-recipe
Nov 19, 2026
Merged

kou merged 2 commits into
enactic:mainfrom
stevenaya:feat/isaac-collision-recipe

Conversation

@stevenaya

@stevenaya stevenaya commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Add V2 collision recipes for the Isaac asset pipeline to select through presets.

Component Group Collision layout
V2 arm split_isaac 28 elements: normal split meshes for the base and links 4–6, simplified three-piece meshes for links 2–3, and the existing single mesh for link1
Pinch gripper split_fingers_5parts 11 elements: the existing base mesh and five normal mesh pieces per finger

Select the groups on the corresponding preset components:

primary_arm:
  collisions: split_isaac
primary_arm_end_effector:
  collisions: split_fingers_5parts

Each group contains the complete collision configuration. Existing default groups and shipped preset selections remain unchanged.

Validation

  • Existing 35 tests pass.
  • All six V2 presets expand with the new group names; the generated URDFs are identical to those generated before the group rename.
  • Collision mesh paths, origins and scales match the Isaac selection recipe, and referenced resources resolve.
  • git diff --check passes.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 12:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI balanced review requested due to automatic review settings November 19, 2026 02:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@kou
kou merged commit 1677e50 into enactic:main Nov 19, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
release — b8fc90b8 Deployed Nov 19, 2026 by stevenaya via Publish #528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants