Skip to content

Fix duplicated link prefixes in split collision names - #145

Open
stevenaya wants to merge 1 commit into
enactic:mainfrom
stevenaya:fix/split-collision-local-names
Open

stevenaya wants to merge 1 commit into
enactic:mainfrom
stevenaya:fix/split-collision-local-names

Conversation

@stevenaya

Copy link
Copy Markdown
Contributor

Changes

Remove link prefixes from collision entry names in the split_isaac arm recipe and split_fingers_5parts gripper recipe introduced by #143. The common emitter already adds the final link name, so these prefixes were duplicated.

  • Arm entries use local names such as 00_motor and 01_plate.
  • Finger entries use string names "00"–"04".

For example, openarm_left_link2_link2_00_upper_collision becomes openarm_left_link2_00_upper_collision. Mesh files, paths, and collision geometry are unchanged.

Validation

  • Existing model contract tests pass.
  • Expanded bimanual URDF comparison confirms only collision names change.

Copilot AI balanced review requested due to automatic review settings November 19, 2026 13:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch was successfully deployed

1 active deployment
release — c80b288c Deployed Nov 19, 2026 by stevenaya via Publish #530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants