Skip to content

Select named visual and collision groups from presets - #142

Merged
kou merged 2 commits into
enactic:mainfrom
stevenaya:feat/geometry-groups
Nov 18, 2026
Merged

kou merged 2 commits into
enactic:mainfrom
stevenaya:feat/geometry-groups

Conversation

@stevenaya

Copy link
Copy Markdown
Contributor

Changes

Allow each preset component to select named visual and collision groups independently:

primary_arm:
  type: arm
  product: openarm_v2.0
  config: null
  visuals: default
  collisions: default
  • Add one group-name level to visuals.yaml and collisions.yaml. Each group contains a complete link-to-geometry mapping; groups are selected directly without inheritance or merging.
  • Move the existing contents of all 16 YAML files under default. Omitting either selector uses default; unknown group names produce an explicit error.
  • Select groups when loading the component description, before the existing mounting and reflection logic. Preserve single-visual and single/compound-collision behavior, including box collisions.

This PR supplies the grouping mechanism and the existing default configurations. Additional mesh recipes can be added as separate groups. The asset changes are YAML nesting only; mesh files and geometry parameters are unchanged.

Validation

  • Existing 35 tests pass. Extend the geometry test to cover independent selection, omitted/explicit defaults, no inheritance, and unknown groups; no new test functions.
  • All 16 preset/standalone/legacy-entry URDF comparisons match the pre-change output.
  • All 16 default mappings match the original YAML data exactly.
  • Package build, formatting checks and git diff --check pass.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 07:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 07:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@kou
kou merged commit 624e3dd into enactic:main Nov 18, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
release — 132befdb Deployed Nov 18, 2026 by stevenaya via Publish #523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants