Repository navigation
setup saves the connection when the pod is slow to connect; stale saved default says so - #38
Merged
Merged
Conversation
…le saved default says so Found swapping pods on one Mac: setup registered the new pod, which had no Ethernet yet, and stopped at step 4 because it did not reach embeddedci.com within 30s. Step 5 never ran, so the CLI kept the previous pod's USB address and the next `benchpod status` timed out with no hint why. - register returns errRegisteredNotConnected for that case (the registration stands); setup carries on to save the connection. - An unreachable pod at the saved default (not --connection or BENCHPOD_CONNECTION) adds that the address is the saved default and to run discover / set-connection. The exit code is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found swapping pods on one Mac (analog baea06 unplugged, digital a1c5c7 set up):
benchpod setupregistered a1c5c7, which had no Ethernet yet, and stopped at step 4 ("did not connect within 30s"). Step 5 never saved the connection, so the CLI kept baea06's USB address.benchpod statusthen timed out at 10.237.8.85:8080 with no hint that this was the saved default.Changes:
errRegisteredNotConnectedwhen the pod is registered but not connected in time; setup prints that it carries on and still saves the connection (step 5). Other register errors still stop it.--connection/BENCHPOD_CONNECTION) adds: " is the saved default connection. If that pod is unplugged or you use another one, runbenchpod discover… thenbenchpod set-connection…". Exit code unchanged (5).Tests:
TestSetupCarriesOnWhenTheRegisteredPodIsNotConnectedYet,TestSavedConnectionHint; checked the hint by hand against the stale default on this Mac.Not in this PR:
--connection a1c5c7/benchpod-a1c5c7is dialed as a hostname; to be verified with a pod plugged in.🤖 Generated with Claude Code