Repository navigation
docs(screenshots): re-shoot after Wave 2 on a stack built from main - #31
Merged
Merged
Conversation
Re-shoot the B7, Wave 2, B4 and B6 screenshots that went stale, on the demo stack built from platform main 4755bdcf. The Explore shots run in the Docs sandbox workspace (DOCS_WS knob); the harness now resets the viewport to 1440x900 before each shot so a tall shot no longer leaks into the next. Three captions and the quoted roles banner follow the new images. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-shoots the screenshots that Wave 2 (#29) and Wave 2b (#30) listed as stale, on the shared demo stack rebuilt from platform
mainat4755bdcf(B6 #728 on top of B7 #727, B4 #726 and Wave 2).egretandfrontendwere rebuilt from that commit;rendererwas not (no change underrenderer/since its image was built). Main was checked live before shooting: the audit log opens on Changes and denials, the audit API returnsactorEmail, the bundle carries Disable user and Waiting for first sign-in, and a Docker engine shows its containers.All shots: 1440x900 (or the height the shot script sets), light theme, one admin session, every PNG viewed.
Re-shot (25)
control-plane/access-control/users.md,audit-log.md,access-control/index.md):admin/cp-audit-log(opens on Changes and denials, actor email),admin/cp-user-detail,admin/cp-users-bulk,control-plane-access-overview(Recent changes by email)members.md,roles-and-permissions.md):admin/ws-members(with a Waiting for first sign-in row and Withdraw),admin/ws-add-member,admin/ws-roles(thedata_api_invokernote, 9 permissions (7 inherited)),admin/ws-roles-expandedquery-engines/engine-detail.md):admin/cp-engine-catalogs,admin/cp-engine-workspaces(a temporary Docker enginedocs-trino, deleted afterwards)alerts-and-reports/index.md,create-an-alert.md):alerts/alerts-list(seven alerts, two Data API alerts, with Success / Error / Not triggered),alerts/detail(Error when one destination fails, each failed destination named)row.md,progress.md,gauge.md,number.md,table.md,the-chart-editor.md):charts/row-data(largest bar on top),charts/progress-data,charts/gauge-display,charts/scalar-display,charts/table-data(display names in the header),charts/editor-export(10,000 rows)export-and-reports.md):dashboards/card-export(10,000 rows)usage-and-preview.md,datasets-and-metrics/index.md):sql-datasets/ds-usage(per-type icons),sql-datasets/ds-preview(display names),sql-datasets/datasets-row-menu(Duplicate)publishing.md,parameters.md,access.md):data-api/endpoint-versions(badge beside the note),data-api/endpoint-params(constraint labels),data-api/endpoint-access(no revoke note on endpoint-only grants)Text changed because a re-shot image contradicts it
access-control/users.md: thecp-user-detailcaption said "two platform roles"; the page lists only directly granted roles (KI-260) and Farid Haddad's direct role issecurity_auditor(hisdata_stewardcomes throughdata-stewards).data-api/endpoints/publishing.md: theendpoint-versionscaption said the badge sits "over its note" (the fixed KI); it is beside it now.workspace-settings/roles-and-permissions.md: thews-rolescaption counted "two custom roles" (the stack has three); the quoted banner now has its second sentence aboutdata_api_invoker.Shot-script changes
scripts/screenshots.mjsresets the viewport to 1440x900 before each shot: a shot that sets a taller viewport no longer leaks it into the next one (it did, and charts came out 1000 px tall).scripts/shots/{alerts,charts,dashboards,data-api,sql-datasets}.mjstakeDOCS_WS(defaultdefault) for the workspace the Explore objects live in. This pass usedDOCS_WS=docs-sandbox, so these shots show the Docs sandbox workspace, like the admin shots.Still stale, and why
admin/gov-overview,admin/gov-table-lineage,admin/gov-tag-exposure(and the rest of thegov-*set): they need thedocs-trinotables indemo_warehouse.analytics, the view, grants, rules and tags ofscripts/shots/admin-demo-data.mdstep 3; not rebuilt in this pass.admin/cp-engines: kept. A re-shot list shows onlydocs-trino; the caption names the external enginetrino-demo-ext, which is not registered on the stack. The kept image already has the Endpoint column.admin/cp-engine-logs: no longer referenced by any page (Docker engines have no Logs); left in place.ops/get-started/sign-inandsign-in-break-glass: re-shot and identical, so not committed. The error message is not on a screenshot.data-api/endpoints-list,admin/cp-users,sql-datasets/datasets-trash.sql-datasets/sqllab-truncatedwas not re-shot: in Docs sandbox (two connections) SQL Lab opens with no database selected.Seed data created on the demo stack
All in the
docs-sandboxworkspace (Docs sandbox), from the docs repo'sscripts/seed-*shapes run against that workspace: the connectionstrino-demoandtrino-sandbox(bothtrino-demo:8080), the datasets, metrics, charts, folders and dashboards ofseed-sql-datasets,seed-charts-deep,seed-dashboards,seed-sql-charts-listsandseed-admin(sandbox part), the Data API service accounts, clients and endpoints ofseed-data-api, the alerts, Data API alerts and reports ofseed-alerts(run once with--run), workspace SMTP pointed at Mailpit, and a pending SSO pre-registrationnina.park@egret.local(ws_viewer). Admin is aws_adminmember of Docs sandbox (the alert owner picker shows a raw user id for an owner who is not a member). Platform-wide, fromseed-admin.mjsunder their documented names (the pages name them): usersalice.nguyen…hiro.tanaka@egret.local(grace.leedisabled), groupsfinance-analysts,marketing,data-stewards,executives, rolesfinance_reporter,marketing_analyst,security_auditor, and the catalogtpch_bench. Other workspaces ofseed-admin.mjs, secrets, storage, tags and access requests were not created. Nothing with theb4-,b6-,b7-ordocs-w2b-prefix was changed;b7_reporterand theb7-users appear in some shots read-only.The build passes for en and vi with
DOCUSAURUS_NO_PERSISTENT_CACHE=1 npm run build.🤖 Generated with Claude Code