Repository navigation
Fix JSON BOM tickets and exception= log fields - #2
Merged
Merged
Conversation
A UTF-8 BOM was stripped only for format detection, so json.loads still rejected the ticket. Text logs documented an exception field but only read error_type, so names like JobFailed collapsed into the message. Co-authored-by: David Kupratis <dkupratis@student.bccc.edu>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two parser fixes from review of #1, which is already merged:
json.loadsthen rejected the original text withUnexpected UTF-8 BOM, soticket2bugexited 2. The BOM is now stripped before the empty check and before decoding.exceptionfield but only readerror_type. Names such asJobFailed,QueueFull, andWorkerStoppedfell through to the shared message and were counted as one repeated issue.exception=is now an explicit type, anderror_typestill wins when both are present.Tests
ruff check .is clean.pytestreports 57 passed on Python 3.11 and 3.12, including a BOM ticket, a BOM-only file, distinctexception=types, anderror_typeoutrankingexception.