Conversation
Flip-only wholesale replace: v13 keeps the app-facing surface (make/passes/fails/
messages/errors/sometimes) but splits the monolithic 4.2 Validator (44 inline validateXxx)
into Concerns traits + Rules/ classes, moves the contract to Contracts\Validation\Validator,
and adds UncompromisedVerifier via Http\Client. v13 Validation\* shadows the fork tree via
the PSR-4 seed mechanism (egulias/email-validator + brick/math already on floor).
- composer: illuminate/validation self.version -> ^13 (v13.33.0).
- Drop tests/Validation/{ValidationValidatorTest,ValidationFactoryTest,
ValidationDatabasePresenceVerifierTest} (vendored behavior; they assert the fork Validator
internals — each()/monolithic layout — gone in v13).
- Container alias 'validator' -> Illuminate\Validation\Factory unchanged (v13 Factory).
Fork suite 461 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 4.3 (L2 per-unit): swap
illuminate/validation→^13(flip-only, wholesale). Stacked di atas #77 (4.2.106 hashing).Perubahan
illuminate/validationreplace→require ^13(v13.33.0; egulias/email-validator + brick/math sudah di floor). v13Validation\*shadow tree fork (PSR-4 seed).Contracts\Validation\Validator.'validator'→Illuminate\Validation\Factory(v13) tak berubah.tests/Validation/{ValidationValidatorTest,ValidationFactoryTest,ValidationDatabasePresenceVerifierTest}(vendored-behavior; assert internal fork —each()/monolitik — hilang di v13).Fork suite 461 hijau.
App matched-pair: dicoding#5916 (memuat L4.2-compat layer global — v13 memperketat beberapa semantik rule).