Conversation
agissept
force-pushed
the
pre-release/4.2.107
branch
from
September 26, 2026 03:09
17e9877 to
6c90f2f
Compare
agissept
force-pushed
the
pre-release/4.2.108
branch
from
September 26, 2026 03:09
3b7fd08 to
ece3949
Compare
agissept
force-pushed
the
pre-release/4.2.107
branch
from
September 26, 2026 03:18
6c90f2f to
915545f
Compare
agissept
force-pushed
the
pre-release/4.2.108
branch
from
September 26, 2026 03:18
ece3949 to
80a0fdd
Compare
Move illuminate/routing from replace (self.version) to require ^13; v13's Routing tree shadows the fork via PSR-4 (seed mechanism). This removes the fork Router's before/after/filter global-filter engine — the last of the task 2.8 filter surface (part 2). Foundation: App::before/App::after no longer delegate to the (now v13) Router, which has no global-filter concept. Store the callbacks on the Application and run them around the route dispatch (before with response short-circuit, after wrapping the response) — the app has no HTTP Kernel to host global middleware. CachedRouting evaporated early (its Router subclass overrides L4.2 Router internals gone in v13 and can't even compile against v13's public newRoute()). The routing swap forces this component's removal ahead of task 4.4. Deleted vendored-behavior tests (now assert v13-owned Router/UrlGenerator/ Redirector/ControllerDispatcher/ResponseFactory internals): Routing/* + Support/SupportFacadeResponseTest + CachedRouting/*. Fork suite 382 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agissept
force-pushed
the
pre-release/4.2.107
branch
from
September 26, 2026 03:37
915545f to
a142be2
Compare
agissept
force-pushed
the
pre-release/4.2.108
branch
from
September 26, 2026 03:37
80a0fdd to
2f5c862
Compare
agissept
marked this pull request as draft
September 26, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 4.3 — routing swap (illuminate/routing v13)
Ninth sub-unit of Wave 4.3. Moves
illuminate/routingfromreplacetorequire ^13(v13.33.0); v13's Routing tree shadows the fork via PSR-4 (seed mechanism). This removes the fork Router's before/after/filter global-filter engine — the last of the task 2.8 filter surface (part 2).Foundation: global before/after without a Router filter engine
App::before/App::afterused to delegate to$this['router']->before/after(). v13's Router has no global-filter concept, so the app (which has no HTTP Kernel to host global middleware) now stores those callbacks on the Application and runs them around the route dispatch:CachedRouting evaporated early
Illuminate\CachedRouting\Routeroverrides L4.2Routerinternals gone in v13 and can't even compile against v13'spublic newRoute(). The routing swap forces this component's removal ahead of task 4.4. Itssrc/+ tests deleted (app drops the provider registration in the matched-pair PR).Deleted vendored-behavior tests
Now assert v13-owned internals:
tests/Routing/{RoutingRouteTest,RoutingUrlGeneratorTest,RoutingRedirectorTest,RoutingControllerDispatcherTest},tests/Support/SupportFacadeResponseTest,tests/CachedRouting/*.Verification
Fork suite 382 green (14 skipped; −64 deleted vendored tests). Stacks on #78.
Remaining 4.3 sub-unit: queue (last L2 unit).
🤖 Generated with Claude Code