Repository navigation
fix: retain emergency-approval findings when the approver is blank - #8
Merged
Merged
Conversation
dev-belly
marked this pull request as ready for review
October 27, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timely emergency-change approval with an approver ID containing only whitespace was treated as complete. That suppressed the missing-approver review item despite there being no identifiable approving person.
Treat empty/whitespace-only IDs as missing while retaining their original source value in the evidence. Add five missing-identity cases and a DuckDB → workpaper ZIP → independent replay regression.
Validation: 115 rule, store, export, review and CLI tests passed locally; full src/tests lint passed. The original whitespace case suppressed the expected finding.