Skip to content

Show all text format buttons in the question card on phones #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilReinking merged 4 commits into from
Oct 17, 2026
Merged

Show all text format buttons in the question card on phones #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a8d95e
Wrap the text format toolbar on phones
PhilReinking Oct 16, 2026
66005bb
Add changelog line for #289
PhilReinking Oct 16, 2026
62a3efc
Fix the changelog line for #289
PhilReinking Oct 16, 2026
0142b05
Merge remote-tracking branch 'origin/main' into fix/bits-294-toolbar-…
PhilReinking Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ Lines marked **Upgrade step** need you to act after updating.
- While the form editor loads your questions, it now shows grey placeholder rows instead of the "Welcome to the Editor" text. When the questions can't load, it says so and offers Try again. Before, a spinner turned forever. (#263)
- A logic rule that uses or goes to a deleted question, or one of another form, is now refused with a message that names the field. Before, it saved and looked like it worked. The blocks API now lists, for each question, the rules that use it (`used_by`). (#264)
- The form editor now shows "Saving…", "Saved" or "Not saved" with Retry. A failed save names the question by number and text, and the red bar offers Retry. Reloading or closing the page right after typing keeps the change, and the browser asks before you leave while a change isn't saved. Before, the editor showed nothing, and a reload within a second lost the change. (#267)
- On a phone, the text format buttons above a question or end screen text now wrap onto more lines, so all of them show. Before, half were hidden past the edge. (#289)
- A webhook answer that isn't valid UTF-8 text is now saved and shows on the submissions page, with each unreadable character as "?". Before, it wasn't saved and the webhook was called up to 5 times. With `QUEUE_CONNECTION=sync`, the submission itself failed with a server error. (#284)
- Opening a question in the editor no longer saves its answer settings, so "Saving…" does not show up for nothing. They save only when you change a setting. (#288)

Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/Factory/Shared/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div
role="group"
aria-label="Text format"
class="mb-1 flex items-center overflow-x-auto [&>div]:shrink-0 lg:flex-wrap lg:gap-y-2"
class="mb-1 flex flex-wrap items-center gap-y-2"
:class="!bare && 'py-1 bg-white border border-grey-300 rounded-lg'"
>
<div class="px-1">
Expand Down
Loading