Repository navigation
Show all text format buttons in the question card on phones - #289
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PhilReinking
left a comment
There was a problem hiding this comment.
OK at 66005bb, one nit. Checked beyond the PR text in Brave at 360, 390, 800, 1024, 1280 px, in all three editors (question, end screen card, Settings end screen): 12 buttons, at least 44x44 below lg, no hidden scroll. The Settings box is narrower, so 4 rows there. From 1024 px the bar matches main. At 800 px main hid buttons too; now they wrap. Typing on a short phone screen keeps the text in view.
|
|
||
| ### Fixed | ||
|
|
||
| - On a phone, the text format buttons in an open question now wrap onto a second line, so all of them show. Before, half were hidden past the edge. (#289) |
There was a problem hiding this comment.
Nit: on a phone it's 3 rows (4 in Settings), and it also covers the end screen text.
| - On a phone, the text format buttons in an open question now wrap onto a second line, so all of them show. Before, half were hidden past the edge. (#289) | |
| - On a phone, the text format buttons now wrap onto more lines, so all of them show. Before, half were hidden past the edge. (#289) |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…on-phones # Conflicts: # CHANGELOG.md
PhilReinking
left a comment
There was a problem hiding this comment.
OK at 0142b05, CI green. Re-check of the changelog merge only: merging main conflicted only in CHANGELOG.md and changes no other file. The code diff vs main is the same as at 62a3efc. The #289 line is word for word as before, 1 line added and 0 removed, right above the #284 line in Fixed. It merges cleanly with #287 and #290, in pairs and all 3 together. The OK at 62a3efc covers the rest.
What changed
On a phone, the text format buttons in an open question now wrap onto extra lines instead of scrolling sideways. All 12 show. Desktop is unchanged.
One class list changed in
Editor.vue: the bar wraps at every width (it did only fromlgup) and no longer scrolls sideways. The buttons already had the 44 px size.Tested
Own server, headless Brave, an open question card,
mainvs this branch. Measured in the browser:npm run lint,npm run vue-tsc,npx vitest run(65 files, 504 tests) pass.Screenshots, before and after side by side at 360, 390 and 1280 px, are on the ticket.
Not tested
Real phone. Only a headless browser at those widths.
I chose wrapping over a "More" button: it meets every criterion with one class change.
Steps after merge: none.
Fixes BITS-294
🤖 Generated with Claude Code