Repository navigation
CLI/API filter fixes: --run --participant, day labels, listRuns array shape - #551
Merged
Merged
Conversation
- bench results --run <id> now accepts --participant; date/step flags
still hard-error on a single run.
- --tz and --source-org alone no longer count as result filters, so
they don't trip the unsupported-platform error on old platforms
(sourceOrg is still sent whenever it's the only flag).
- The results table labels each row with the run's day instead of its
UUID (participant, step and empty-run rows alike).
- client.listRuns returns an array again: the {items,filter,upgrade}
envelope attaches as non-enumerable items/appliedFilter/upgrade so
pre-0.8.0 callers iterating the result keep working.
- client.getRunResults takes { participants } -> ?participant=.
- Tests for relative --since, --day conflicts, --steps scope, empty
--participant, tz/source-org flag semantics and the missing-echo error.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
….ts fallback
listRuns now resolves to the array-shaped BenchmarkRunListResult — the
scale aggregate script's { items: [] } fallback didn't fit; use a real
empty array and re-export the new types through @benchsdk/runner.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
dtice25
marked this pull request as ready for review
October 24, 2026 17:47
Contributor License AgreementAll contributors are covered by a CLA. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Devin resolved all 2 findings on 80fa737
Fixed by Devin (2)
- Result rows show the wrong local day
- Source organization silently ignored in all-runs listing
View all findings in Devin Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI/API follow-up to the filter work in #537, pairing with the platform fixes in benchmarks-platform (draft PR on
devin/1792795195-benchmark-filter-fixes).bench results --run <id>now accepts--participant→getRunResultssends?participant=;--since/--until/--day,--stepsand--source-orgstill hard-error on a single run since the route has no dimension to apply them to.resolveResultFilter'sflagsSentno longer counts--tzor--source-org— either flag alone previously tripped the "platform does not support result filters" error on older platforms, and--source-orgalone also silently stopped being sent.sourceOrgis now passed through independently offlagsSent.client.listRunsreturns the items array again (pre-0.8.0 shape). The envelope attaches as non-enumerableitems/appliedFilter/upgradesofor (const run of result)andresult.itemsboth work,JSON.stringifystill sees a plain array, andfilterdoesn't shadowArray.prototype.filter.bench runs list --jsonreconstructs{items, filter, upgrade}for output.run.createdAtslice, falling back to a short id) instead of the full run UUID.--since/--until,--dayconflicts and expansion,--stepsscope, empty--participant,--tz/--source-orgflag semantics, andassertFilterEcho's missing-echo error.Verified:
benchsdk-cli43 tests pass,benchsdkcontract tests pass (the live-platformintegration.test.tssmoke fails identically onmaster—updateRun400 against the live API, unrelated).Link to Devin session: https://app.devin.ai/sessions/4318a1ae3bf3444f8c96d1dd95ae3c9b
Open in Devin Desktop: https://app.devin.ai/desktop/session/4318a1ae3bf3444f8c96d1dd95ae3c9b?variant=devin
Requested by: @dtice25