Repository navigation
Review fixes: tz-aware run labels, guard bare --source-org on runs list - #556
Merged
Merged
Conversation
- runDay labels result rows by the filter's timezone (en-CA/YYYY-MM-DD) instead of the UTC date — runs near midnight now match the day the user filtered on; falls back to short id / UTC slice. - bench runs list --source-org with no slug now errors instead of silently listing all visible runs (listAllRuns has no org dimension); flag validation moved before API client setup. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
dtice25
marked this pull request as ready for review
October 24, 2026 17:51
Contributor License AgreementAll contributors are covered by a CLA. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Devin resolved all 2 findings on 99bba1c
Fixed by Devin (2)
- Empty source organization lists all runs
- Invalid-zone fallback mislabels offset timestamps
View all findings in Devin Review
- --source-org= (empty value) now errors instead of silently dropping to an unscoped listing. - runDay's invalid-zone fallback labels by the true UTC date (toISOString slice), not the timestamp's own offset date. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…e timers The 1ms deadline could expire before runWorker was dispatched on a slow machine, leaving calls.runWorker empty. Fake timers hold the clock at the deadline boundary until the task's own timer runs out. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two Devin Review findings on #551 (merged):
runDaynow labels result rows in the filter's timezone (toLocaleDateString('en-CA', { timeZone })) instead of the UTC date — a run created at 02:00Z inAmerica/New_Yorkwas labelled with the wrong day when the user filtered with--day/--tz. Falls back to a short run id whencreatedAtis absent and to the UTC slice when the zone is unrecognised.bench runs list --source-org <org>with no benchmark slug now throws--source-org requires a benchmark sluginstead of silently listing all visible runs (listAllRunshas no org dimension). Flag validation moved beforecreateApiClientso a rejected command doesn't need credentials.Tests:
runDayzone conversion + fallbacks, bothhandleRunsListslug guards. 47 tests pass.Link to Devin session: https://app.devin.ai/sessions/4318a1ae3bf3444f8c96d1dd95ae3c9b
Open in Devin Desktop: https://app.devin.ai/desktop/session/4318a1ae3bf3444f8c96d1dd95ae3c9b?variant=devin
Requested by: @dtice25