Repository navigation
Fix date-dependent recurrence and demo regression tests - #322
Open
callumalpass wants to merge 2 commits into
Open
callumalpass wants to merge 2 commits into
callumalpass wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause and smallest fix
Main run 41043845004 failed because the evening recurrence regression supplied an October 27 mutation timestamp but let the pinned model's recurrence helper read the real system date. Once October 29 passed, it advanced to a later occurrence. Freeze and restore the system clock in that test. No production code, model inputs, or expected behavior changed. No existing open PR covered the failure.
The requested full browser preflight crossed into Saturday and exposed three more tests assuming exactly four overdue demo tasks. The demo has five on Saturday. Those tests now measure the actual initial count and assert the exact move/completion/undo delta, rather than hard-coding a weekday.
Validation
Before opening:
At current head c91b7cc:
Nothing merged; no workflow dispatch, store submission, or deployment performed.