Skip to content

Remove legacy Connect client; pin UI and i18n to beta.148 - #323

Open
callumalpass wants to merge 3 commits into
mainfrom
chore/sdk-current-production
Open

callumalpass wants to merge 3 commits into
mainfrom
chore/sdk-current-production

Conversation

@callumalpass

Copy link
Copy Markdown
Owner

Scope / order

Built on #322's separate date-dependent CI fixes; review and merge #322 first. This PR targets main so the existing Android/iOS PR gates actually run. Its diff will shrink when #322 lands. No merges or release/deploy/store workflow dispatches were performed.

Remove the legacy path, do not preserve a fallback

The main app already constructs NextTaskRepository from the held SDK connection. The old MdbaseTaskRepository/client were still used by application test fixtures and benchmarks, and these live/shared helpers still depended on the old package:

  • Assigned-to-me queries: emit the same escaped authority-resolved link CEL through SDK pages; no basename matching or substitute query path.
  • People display and model/resource provision types: use SDK PeopleDirectory/sameIdentity and unchanged declaration data.
  • Notification registration and wake handling: selected SDK connection timers.registerWebPush/registerFcm and SDK envelope parsing/display. The unreachable old cloudSession, native signed-authority HTTP plugin and handwritten envelope parser are deleted. This does not enable the separately disabled production reminder feature.
  • Unknown writes: SDK MdbaseError/mutationId, not a legacy outcome wrapper. Only outcome_unknown errors retain a recovery ID; rejected receipts cannot pin deletion retries forever.
  • Tests and benchmarks: original SDK MemoryReplica, not an emulated legacy connection. All 30 repository behavior cases are preserved against the current SDK, with its bounded-prefix/complete-replacement view semantics. A pre-aborted empty list now correctly honors cancellation.

Delete the beta125 query-patched archives/patch, unused legacy repository/session/mutation/file/view/transport code, connect-dev/testing dependencies and connect/connect-sync overrides. Add release regression checks that no legacy package is installed or imported.

Package/input limits

  • Exact npm @mdbase-dev/ui and @mdbase-dev/i18n: 0.1.0-beta.148; pnpm 10.7.0 refreshed the lockfile and integrity assertions.
  • SDK eaa4e697 production-beta141 and obsidian-runtime 07ae574c/991106d7 original bytes and pins unchanged.
  • The unchanged protocol original remains a manifest-builder/validator/native-publisher input, also bundled by the SDK; no standalone legacy client remains.
  • Vendored mdbase, TaskNotes model/spec/NLP inputs, generated declarations/catalogues and app/store versions unchanged.
  • Persisted task-pack setup journals and delayed-deletion authorityRequestId journals keep their existing formats/identities. No data migration, compatibility shim, feature flag or fallback introduced. No flow remains dependent on the deleted package.

Validation before opening

  • Full pnpm verify via rpnpm: PASS. i18n, release guards (396 pass / 1 existing skip), formatting, typecheck, lint, coverage (231 files / 1,868 tests), application/domain layer thresholds (137 / 251 tests), TaskNotes conformance (4,982 pass / 1 existing skip), mdbase oracle and production build.
  • Full pnpm test:e2e on final source: PASS, 314 desktop/mobile tests / 20 existing skips. Safety net blocks external authorities. This is local stand-in/demo evidence, not real-account LAB/production qualification.
  • pnpm bench:collections via rpnpm: PASS, all 3 benchmark files, including default 10k/50k sizes and benchmark TypeScript check. No historical performance reports replaced.
  • pnpm exec cap sync ios and android: PASS, from the verified production build.
  • Java 21 Gradle :app:testDebugUnitTest :app:lintDebug :app:assembleDebug: PASS (248 tasks).
  • iOS Xcode simulator compilation cannot run on Linux; the normal PR iOS gate will compile the standard Capacitor controller after removing the obsolete native transport.
  • Independent read-only review found deletion-recovery and lost-contract-suite issues; both addressed with deterministic regression coverage. No human/GitHub approval implied.

No deployment, tag, app/store version bump, submission, or release.

@callumalpass

Copy link
Copy Markdown
Owner Author

Final head 40dfdcc: Android build SUCCESS (41072781242), iOS simulator build SUCCESS (41072781140), production-smoke PR check SUCCESS (41072781081). Android release job skipped, as expected for a PR. Full local browser suite: 314 passed / 20 existing skips; full verify: 1,868 unit/component tests plus all release/coverage/conformance/build gates passed; all three benchmark files and Java 21 Android unit/lint/debug tasks passed. No merge, dispatch, store submission or deployment. No GitHub reviews/approvals yet. Merge #322 first.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant