Skip to content

fix(catalog-import): match guard, fill-only precedence, and names that resolve - #675

Merged
brickbots merged 2 commits into
mainfrom
fix/catalog-matching-precedence
Oct 24, 2026
Merged

brickbots merged 2 commits into
mainfrom
fix/catalog-matching-precedence

Conversation

@brickbots

Copy link
Copy Markdown
Owner

Part of #670 (PR 2 in its plan).

How a catalog listing joins a sky object, and what it may change when it does: #670 items 1, 3, 4, 12, 13 (the lettered part) and 22. A second commit fixes a declination-sign bug in five loaders that the match guard brought to light. Every rule below is documented in docs/ax/catalog.md §9.1 (precedence) and §9.3 (matching).

What and why

Match guard (item 1). An aka joins an existing sky object only if match_guard passes. Two tests:

  • Types. A star (*, D*, **, maybe with a trailing ?) joins only a star, and anything else joins only a non-star. An unknown type (?, -, empty) and a star group (***, Steinicke's *3/*4) are compatible with either kind. The guard reads the loaders' own type strings, before fix_object_types normalises them.
  • Distance. The listing lies within 30′ of the sky object (great-circle), or within the object's major axis if that is larger.

The akas are tried in source order, and the first one that resolves and passes decides the join. A rejection is logged as a warning, kept in MATCH_REJECTIONS, and counted at the end of the import ("Match guard rejected N joins"). It never fails the import, and the listing becomes a sky object of its own.

One lookup, through the allowlist. ObjectFinder used to try mappings.get(name.lower()) before parse_designation, so an unspaced "B53" or "h99" skipped the allowlist. It now keys on (catalog_code, sequence) and resolves only through listing_named (which is parse_designation). corrections.resolves_to asks the same helper, so the correction pass's checks can't drift from the loaders. astro_data/corrections/README.md and the H24 case in test_resolves_to_asks_the_loaders_lookup_question (now False, with B53 added) follow. parse_designation and CATALOG_CODE_ALIASES are unchanged.

Precedence (item 3). When a listing joins a sky object an earlier loader created, NewCatalogObject.fill_joined_object applies the §9.1 table:

  • it fills an empty magnitude (filter_mag == 99) or an empty size, and replaces nothing;
  • a listing whose akas resolve to more than one sky object describes the group, so it fills nothing (Ta2 52 "2237;2244" and Ta2 45 "1973;1975;1977" are the two fills this removes today);
  • Harris replaces the magnitude (MAGNITUDE_REPLACED_BY: every Harris listing is a Milky Way globular);
  • EGC sets Gb (TYPE_SET_BY);
  • position and type stay the first loader's.

The exceptions live in those two constants and in the table, not in a loader.

Names (item 4). A PiFinder-catalog designation is stored as a name only if it resolves to the listing's own sky object. If it resolves to nothing, it is dropped from a joined sky object and kept on one the listing mints. Common names and other catalogs' numbers (UGC, SIMEIS) are always stored. An aka the object already has under another origin is stored again: origin is per-loader provenance, and get_object_id_to_names drops repeats when the device loads names.

Load order. Collinder, then Sharpless, then Caldwell. See the cycle below for what that order decides.

Caldwell (item 22). caldwell_akas handles the other-name field:

  • "a/b" and "a-b" become two designations, the second replacing the first's trailing digits ("NGC 6992/5" is NGC 6992 and 6995);
  • "none" names nothing;
  • a designation the allowlist reads whole stays whole, so "Sh2-155" is no longer add_space_after_prefix's "Sh 2".

Caldwell fills a missing magnitude through the general rule. Its only fill today is C 100's 4.5 on IC 2944: Collinder fills C 37 first (see the cycle).

Barnard (item 12). Typed DN, not Nb.

Arp lettered components (item 13), opt-in. Agreed with the coordinator: the shared default stays strict, and only the Arp loader sets lettered_components=True.

  • "X nnnnA" resolves to X nnnn's sky object only if the listing doesn't also name X nnnn. PiFinder's NGC 4676 is Steinicke's A row, while Arp 77's NGC 1097A is a companion beside NGC 1097.
  • Any other letter resolves to nothing, so Arp 79's NGC 5490C, a galaxy 4.8′ from NGC 5490, stays its own.

Two-axis sizes major-first. parse_arcmin_size sorts a size with exactly two extents, because SizeObject keeps [major, minor]. The fill now writes Collinder's "25x30" for IC 1590, and the audit's findings.py refuses a minor axis larger than the major. Sizes with one extent, or three or more, keep their order.

Declinations between −1° and 0° (second commit). This bug wasn't on #670's list; it is the same class as items 15 and 17, and the guard found it. Harris, TAAS, Barnard, Collinder and Lyngå applied the sign by negating the whole degrees, so "−00" came out north. On main a joined listing hid this behind the first loader's position. With the guard, Har 102, Har 143 and Ta2 129 were rejected and would have become sky objects at mirrored positions. Each loader now uses calc_utils.dms_to_dec. Caldwell's identical code gets the same fix (no −00 rows today). RASC and SAC are untouched (PR 4).

Docs. In §9, the verified rebuild command and the reproducibility caveat below. In §9.1, the precedence table with the group rule, and the load-order cycle. In §9.3, the compatibility rule, the akas-to-names rule and lettered components.

Data effect

Built from python/ with python -m PiFinder.catalog_imports.main, starting from the committed DB. Compared with the baseline worker's baseline.db (main at cfcf4e0), and findings.py run on both.

  • Reproducible. Builds with PYTHONHASHSEED 0, 1 and 7 are byte-identical, and the committed tree reproduces the measured DB. The import rewrites the existing file in place, so SQLite's header counters (change counter, schema cookie) carry over from whatever file was there. A build on top of a previous build differs in those bytes alone. This holds on main too: back-to-back builds go 601 → 615 → 629. §9 now says so.
  • Log. 32 warnings (main: 20; the 12 new ones are the guard rejections), no errors, 0 corrections.
  • Rows. objects 149,313 → 149,312; catalog_objects 151,170 (unchanged); names 430,288 → 430,128; object_images follows objects, and no object's image name changed.

Findings: 1,366 → 1,329 (52 removed, 15 added)

category baseline PR 2 Δ
size_missing 77 63 −14
magnitude_missing 74 61 −13
size 127 122 −5
kind 164 162 −2
name 80 78 −2
position 109 108 −1
every other category 735 735 0
total 1,366 1,329 −37

Removed (52). Each has a verdict, and each new value matches the verdict's correct value.

  • Fills (13 magnitude_missing):

    object fill
    IC 5146 7.2
    M 17 6.0
    M 20 6.3
    NGC 956 8.9
    NGC 1980 2.5
    NGC 2175 6.8
    NGC 2252 7.7
    NGC 3324 6.7
    NGC 4230 9.4
    NGC 6507 9.6
    NGC 6647 8.0
    NGC 7129 11.5
    NGC 7296 9.7
  • Size fills (3 size_missing):

    • NGC 1931: 4′×4′ (verdict: about 4′);
    • NGC 2467: 15′ (verdict: 8–16′);
    • IC 1590: 30′×25′, which the verdict says is wrong (see added).
  • Harris replaces (5 magnitude):

    • M 107: 7.93;
    • NGC 6287: 9.35;
    • NGC 6352: 7.96;
    • NGC 6569: 8.55;
    • NGC 6365's companion row, which goes with the names.
  • EGC sets Gb (2 kind): NGC 1835, NGC 1916.

  • Barnard DN:

    • kind B 33;
    • name B 33 also drops out, but only because B 33 now draws as a dark nebula: "Horsehead Nebula" is still PR 7's (ngc2000_names.toml).
  • Caldwell (name C 14): C 14 now sits on NGC 869.

  • Names (item 4) and Arp letters (15). The companions' numbers no longer sit on the main galaxies, so OpenNGC's companion rows stop joining them:

    • position: NGC 1097, 1232, 1253;
    • size: NGC 1097, 1232, 1253, 2735, 3769, 5679, and NGC 7317 twice;
    • magnitude: NGC 1097, 1253;
    • name_catalog_only: NGC 7317 twice.
  • Arp lettered joins (11 size_missing): Arp 170, 176, 236, 242 and 278 now take their NGC/IC object's size.

Added (15). None has a verdict yet; my reading of each:

  • Magnitudes now right, OpenNGC's off by more than 1.0:
    • M 17 6.0 and M 20 6.3 are the audit's own correct values (its verdicts call OpenNGC's V wrong);
    • M 22 5.10, NGC 5139 3.68, NGC 6362 7.73 and NGC 6522 8.27 are Harris V_t, the reference by decision.
  • NGC 6885 (C 37): magnitude, kind, position. It now has a magnitude (Collinder's 8.1, see the cycle), so the atlas draws it and its old Ast/position problems show:
    • kind: PR 3's status-4 rule;
    • position: the audit's C 37 structure verdict (PR 3 / PR 7);
    • 8.1: a PR 7 correction to 5.9.
  • NGC 6800 position (3.4′). Drawn now that Lyngå fills its magnitude (10.0). Steinicke's position, no verdict yet.
  • IC 1590 size. Collinder's 30′×25′ against Corwin's 6′×4′: a PR 7 correction (see below).
  • NGC 2467 size. 15′ is inside the verdict's 8–16′, so OpenNGC's 4.2′ is the one that's wrong.
  • NGC 7429 size. Lyngå's 15′ against OpenNGC's 4.5′. Unverified: worth a look.
  • name_catalog_only C 9. The Cave Nebula object now carries Sharpless's "CAVE", which OpenNGC lacks. Harmless.
  • name_catalog_only NGC 4676. "NGC 4676A" from Arp 242, stored by the lettered rule.

The other 62 changed findings keep their identity. 20 are Harris magnitudes that now equal the verdicts' correct values (NGC 6401 7.4 → 9.45, NGC 6235 8.9 → 9.97, NGC 5946 8.4 → 9.61, IC 4499 10.1 → 9.76…). The rest are name and listing-order changes from items 4 and 22 (NGC 884 off NGC 869; NGC 4039, 4438 and 4568 off their pair; IC 63 off IC 59; NGC 2175 off NGC 2174; the Copeland's Septet and Stephan's Quintet members off NGC 3746 and NGC 7317; "none" and "Sh 2" gone), or catalog_entries order.

Match guard: every rejection on today's sources

The first build rejected 16. The −00 commit removes 3 of them (they were the loader bug, not mismatches), and the star-group rule removes 1. 12 remain:

listing aka → sky object why verdict
Arp 65 (Gx) "NGC 0091" → NGC 91 (*) types Gx / * Correctly rejected. Arp 65's position is NGC 90's, and Arp 65 is NGC 90 + 93: arp.sqlite's "NGC 0091" is wrong. PR 7: same_as = "NGC 90".
Col 33 (OC) "IC1848" → IC 1848 (OC, 18′) 59.3′, limit 30′ Correctly rejected. Collinder gives IC 1848 for Col 32, 33 and 34, three clusters in W5. Col 32 stays on IC 1848.
Col 34 (OC) "IC1848" → IC 1848 71.1′, limit 30′ Correctly rejected, as Col 33.
Col 208 (OC) "IC2488" → IC 2488 (OC, 18′) 42.8′, limit 30′ Needs a check. Collinder has −57°40′; IC 2488 is at −56°57′, where Lyn 488 joins it. Probably a slip in collinder.txt; a PR 7 correction if confirmed.
Col 314 (OC) "NGC 6222" → NGC 6222 121.3′, limit 30′ Correctly rejected for now. Collinder and Lyngå agree on a cluster at 16 49.5 −44 43. Steinicke makes NGC 6222 a duplicate and places it on NGC 6259 (17 00.8 −44 39). The identification is Corwin's call (PR 3 / PR 7).
Lyn 701 (OC) "NGC6222" → NGC 6222 117.9′, limit 30′ As Col 314.
Lyn 866 (OC) "NGC6846" → NGC 6846 (0.8′) 119.9′, limit 30′ Needs a correction. Lyngå's +30°21′ against NGC 6846's +32°21′, where Col 410 joins it: a 2° slip in Lyngå. PR 7: the position, or same_as.
Lyn 919 (OC) "NGC6996" → NGC 6996 (5′) 51.4′, limit 30′ Needs a correction. Lyngå's position is NGC 6997's (20 56.5 +44 37 against Steinicke's +44 39), so Lyngå's "NGC 6996" is NGC 6997. PR 7: same_as = "NGC 6997".
Har 133 (Gb) "Arp2" → Arp 2 (Gx) 5,321′, limit 30′ Correctly rejected. Harris's Arp 2 is the globular in the Sagittarius dwarf, not Arp's galaxy 2. Follow-up: harris_loader files "Arp 2" as a catalog designation, so item 4 now drops it from Har 133's names. It should be a common name.
Sh2 5 (Nb) "NGC6357" → NGC 6357 (25′) 261.2′, limit 30′ Correctly rejected. akas.csv's "5;NGC6357" is wrong (NGC 6357 is Sh2-11). NGC 6357 also loses the stray names "Sh2 5" and "NGC6357".
Sh2 238 (Nb) "NGC1554" → NGC 1554 (D*) types Nb / D* Correctly rejected by the rule. Steinicke identifies NGC 1554 (Struve's lost nebula) as a star pair, so Sh2 238 becomes a nebula of its own.
Sh2 296 (Nb) "IC2177" → IC 2177 (20′) 50.3′, limit 30′ Correctly rejected (Rich decided). Sh2-296 is the whole Seagull (Sharpless: 200′) and IC 2177 its head. Accepting the listing's own size would let this join pass, but Sh2 296 keeps its own centre and size as a sky object of its own, so the guard stays on the joined object's size only.

Removed by the −00 commit: Har 102 → NGC 6535 (35.6′ = 2 × 17.8′), Har 143 → M 2 (98.8′ = 2 × 49.4′), Ta2 129 → NGC 4666 (55.8′ = 2 × 28′). All three now join at the right position.

Removed by the star-group rule: Lyn 921 (OC) → NGC 6994 = M 73 (***, 2.4′) now joins.

Accepted joins nearest the limit. 1,364 guard evaluations in all. Those more than 15′ apart:

listing aka separation limit
Ta2 39 Col 50 123.4′ 330′ (Hyades)
Sh2 54 NGC6604 29.6′ 30′
Ta2 52 NGC 2237 24.8′ 80′
Lyn 106 NGC1252 22.6′ 30′
C 49 NGC 2237 20.8′ 80′
Sh2 185 IC59 20.7′ 30′
Lyn 215 NGC2239 20.5′ 30′
Lyn 802 NGC6647 19.9′ 30′
Lyn 449 NGC2632 19.6′ 70′
Lyn 230 NGC2262 19.0′ 30′
Lyn 1121 NGC2175 18.9′ 40′
Lyn 218 NGC2250 17.4′ 30′
Lyn 715 NGC6318 17.1′ 30′
Lyn 524 NGC3247 17.0′ 30′
Sh2 31 IC1275 16.2′ 30′
Arp 203 NGC 3712 15.9′ 30′
Lyn 854 NGC6811 15.7′ 30′
Sh2 86 NGC6820 15.4′ 30′

Sh2 54 → NGC 6604 passes by 0.4′.

The Lyngå → Collinder cases in the brief don't occur on today's sources. lynga_loader.identify_catalog_type knows "Col" but not "Collinder", so Lyngå's 67 "Collinder nnn" names are stored as common names and never reach the matcher. #671's description expected them to join. If that is ever fixed, the guard would reject 3 of them:

  • Lyn 639 → Col 285: 1,222′ (the UMa moving group);
  • Lyn 855 → Col 401: 40′ (the −00 sign, below);
  • Lyn 829 → Col 394: 39′.

It would accept the rest, among them Lyn 163 → Col 65 (26′, Col 65's 220′ size), Lyn 780 → Col 367 (18.7′), Lyn 155 → Col 464 (17.1′), Lyn 529 → Col 223 (16.0′), Lyn 505 → Col 213 (13.2′), Lyn 350 → Col 467 (12.1′), Lyn 735 → Col 338 (10.3′) and Lyn 55 → Col 21 (10.1′). Lyn 91 and 92 would now find Col 33 and Col 34 as objects of their own.

Arp: joins that change with the lettered rule

listing Arp's names joins through sky object
Arp 59 NGC 0341A, NGC 0341B NGC 0341A NGC 341
Arp 85 M51A, M51B M51A M 51 = NGC 5194. "M51B" (NGC 5195) is not a name of M 51.
Arp 122 NGC 6040B, NGC 6040A NGC 6040A NGC 6040
Arp 149 IC 0803B, IC 0803A IC 0803A IC 803
Arp 170 NGC 7578A, NGC 7578B NGC 7578A NGC 7578
Arp 176 NGC 4933A, B, C NGC 4933A NGC 4933
Arp 236 IC 1623A, IC 1623B IC 1623A IC 1623
Arp 242 NGC 4676A, NGC 4676B NGC 4676A NGC 4676
Arp 278 NGC 7253A, NGC 7253B NGC 7253A NGC 7253
Arp 79 NGC 5490C (none) stays its own sky object, named "NGC 5490C"

Only the A name is stored on the base object (NGC 4676B, NGC 4933B/C, M51B… are not).

Where Arp also lists the plain number, the join is unchanged and the lettered companion is no longer a name of the main galaxy:

  • Arp 41: NGC 1232A;
  • Arp 77: NGC 1097A;
  • Arp 279: NGC 1253A;
  • Arp 287: NGC 2735A;
  • Arp 280: NGC 3769A;
  • Arp 274: NGC 5679A/C;
  • Arp 319: NGC 7318A/B, 7319 and 7320.

Item 4 drops 129 Arp names in all.

Precedence

  • 30 magnitude fills and 4 size fills. The size fills are NGC 2467 15′, NGC 1931 4′×4′, IC 1590 30′×25′ and IC 1275 8′ (Sh2 31). The group rule removed two more magnitude fills: Ta2 52's 4.8 on NGC 2237 and Ta2 45's 4.2 on NGC 1973.
  • 107 Harris replacements, one for each sky object Harris joins. Every replaced magnitude belongs to an object with a Harris listing, for example NGC 5139 5.3 → 3.68, M 12 6.1 → 6.70, NGC 6522 9.9 → 8.27, M 2 6.6 → 6.47, NGC 6535 9.3 → 10.47.
  • 2 EGC type changes (NGC 1835, 1916: OC → Gb), and 343 Barnard objects Nb → DN.

The load order is a cycle, and no order of Collinder, Sharpless and Caldwell gets every value right:

sky object Col Sh2 C right (the audit) needs
NGC 6885 = C 37, magnitude 8.1 — 5.9 about 5.9 C before Col
NGC 2467, size 15′ 45′ — about 8–16′ Col before Sh2
NGC 1931, size 4′ 7′ — about 4′ Col before Sh2
C 9 joins Sh2 155 Sh2 before C

The brief's order (Col, Sh2, C) gets C 9, NGC 2467 and NGC 1931 right. C 37's 5.9 becomes a PR 7 correction of Collinder's 8.1. Measured by diffing two scratch builds: nothing else depends on the relative order of the three. The same table is in §9.1.

Names. By origin, item 4 drops:

origin names dropped
Arp 129
Ta2 9
Sh2 8
C 6
Abl 4
Col 4
Lyn 3
Har 1

Caldwell adds 4: "Sh2-155", "NGC 869", "NGC 6992" and "NGC 2237" replace "Sh 2", "NGC 869/884", "NGC 6992/5", "NGC 2237-9" and "none". The four Abell names are the listing's own "Abl n", which Abell's aka list repeats: insert() adds that name anyway, so nothing is lost.

Declinations between −1° and 0°: position before → after

listing source before after
Har 102 = NGC 6535 −00 17 49 +0.2964°, rejected −0.2964°, joins NGC 6535
Har 143 = M 2 −00 49 23 +0.8231°, rejected −0.8231°, joins NGC 7089
Har 35 = Pal 5 −00 06 41 +0.1114° −0.1114°
Har 58 = Pal 15 −00 32 31 +0.5419° −0.5419°
Ta2 96 = NGC 3521 s00 02 +0.0333° (joined, 4′ off) −0.0333°
Ta2 129 = NGC 4666 s00 28 +0.4667°, rejected −0.4667°, joins NGC 4666
B 326 − 0 23 +0.3833° −0.3833°
Col 401 −00º 20′ +0.3333° −0.3333°, but see below
Lyn 229 −00 54 +0.9000° −0.9000°
Lyn 267 −00 15 +0.2500° −0.2500°
Lyn 306 −00 59 +0.9833° −0.9833°
Lyn 834 −00 31 +0.5167° −0.5167°

Col 401 is now read faithfully, but its source is probably wrong. Lyngå has the same cluster (Lyn 855, which it names "Collinder 401") at +00°20′, and its B1950 +00°13′ precesses to that. The old sign bug happened to agree with Lyngå. Worth a PR 7 check against SIMBAD/WEBDA.

Left for PR 7

Corrections:

  • C 37 (NGC 6885) magnitude 5.9, was 8.1: a correction of Collinder's value for Col 417.
  • C 41 same_as = "Col 50". caldwell.dat names no designation for it ("none"), so no loader order can join it.
  • IC 1590 size 6′×4′ (Corwin), was.size = "30'x25'". Collinder now fills it.
  • Lyn 919 same_as = "NGC 6997".
  • Arp 65 same_as = "NGC 90".

Redundant now: NGC 1931's missing-size correction, since Collinder fills 4′×4′ = the verdict.

Check, and correct if confirmed:

  • Lyn 866's position (or same_as NGC 6846);
  • Col 208's declination;
  • Col 401's declination (+00°20′);
  • NGC 6222's identification (Corwin);
  • NGC 7429's 15′ (Lyngå).

Left for later

  • Lyngå's "Collinder nnn" names. They are common names, not akas, so those joins never happen (lynga_loader.identify_catalog_type). A follow-up PR, stacked on this one, teaches the Lyngå loader "Collinder" and makes Harris file "Arp 2" as a common name (Har 133 above).
  • Harris "Arp n". The globulars Arp 1 and 2 are classified as Arp-catalog designations; they should be common names.
  • Caldwell's planetary sizes ("0.3/5.8") mean inner/halo, not two axes. They fill nothing today, but the major-first sort would make the halo the major axis if they ever did.
  • The guard's size term uses the joined object's major axis only (Sh2 296 above). Rich decided to keep it that way.
  • TAAS's "B 86" and "B 92". They don't join Barnard: TAAS loads first, and a bare "B" is off the allowlist without extra_aliases.

Testing

  • tests/test_catalog_matching.py (new, 79 tests, on a fixture DB, never the committed one):
    • the guard: types, star groups, unknowns, the 30′ limit, the size limit, great-circle distance, logging, MATCH_REJECTIONS, trying the next aka;
    • the lookup: "B53"/"h99" rejected, "Barnard 53"/"NGC0869"/"Sh2-155" accepted;
    • precedence: fill, never replace, first fill stands, group listings, both exceptions, type and position stand;
    • names: member numbers, unresolved on joined vs minted objects, common names, the WDS path;
    • lettered components: parse_component, Arp 242/85/77/79, the strict default elsewhere;
    • the load order and the Caldwell other-name cases;
    • the load_caldwell, load_barnard, load_arp, load_taas200 and load_collinder loaders on fixture sources;
    • a −00 row for Harris, Lyngå, TAAS, Barnard, Collinder and Caldwell.
  • test_size_parsing.py: two-axis sizes major-first, three-extent order kept.
  • test_catalog_corrections.py: resolves_to follows the shared lookup.
  • nox -s lint, format, type_hints, smoke_tests (5 passed) and unit_tests (1,775 passed): all green.
  • A local DB build, findings.py against the baseline, and three reproducibility builds, as above. The DB is not committed (PR 7).

🤖 Generated with Claude Code

brickbots and others added 2 commits October 23, 2026 19:10
…t resolve

A listing's aka joins an existing sky object only if the match guard
passes: compatible types (a star only with a star; an unknown type or a
star group, "***", with either) and within 30' of the sky object, or
within its major axis where that is larger. A rejected join is logged and
counted, and the listing stays a sky object of its own. Every lookup now
goes through the designation allowlist: listing_named is the one question
ObjectFinder and the correction pass's resolves_to ask, so an unspaced
"B53" or "h99" no longer slips past it.

A listing that joins an earlier loader's sky object fills an empty
magnitude or size and replaces nothing, but for the two exceptions in
catalog.md 9.1: Harris replaces a globular's magnitude, and EGC sets Gb.
A listing whose akas resolve to more than one sky object describes the
group and fills nothing. Only akas that resolve to the listing's own sky
object are stored as its names, so NGC 884's number no longer sits on
NGC 869.

The Arp loader opts in to lettered components: "NGC 4676A" resolves to
NGC 4676 when the listing doesn't also name NGC 4676, and any other
letter resolves to nothing. Collinder and Sharpless load before Caldwell.
Caldwell splits "a/b" and "a-b", skips "none" and keeps "Sh2-155" whole.
Barnard is typed DN. parse_arcmin_size keeps a two-axis size major first,
since the fill can now write Collinder's "25x30".

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…egrees

Five loaders applied a declination's sign by negating its whole degrees,
which loses it at "-00": Harris (NGC 6535, M 2, Pal 5, Pal 15), TAAS
(NGC 3521, NGC 4666), Barnard (B 326), Collinder (Col 401) and Lyngå
(Lyn 229, 267, 306 and 834) put those objects north of the equator. A
joined listing hid it behind the first loader's position, until the match
guard measured the distance: Har 102, Har 143 and Ta2 129 were refused,
and would have become sky objects at their mirrored positions. Each loader
now reads the sign on its own through calc_utils.dms_to_dec; Caldwell's
identical code has no such row today and gets the same fix.

RASC and SAC have the same bug and are #670 items 15 and 17.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant