Skip to content

fix(catalog-corrections): cited corrections for about 220 objects, and stricter correction checks - #694

Merged
brickbots merged 9 commits into
mainfrom
fix/catalog-corrections-data
Nov 10, 2026
Merged

brickbots merged 9 commits into
mainfrom
fix/catalog-corrections-data

Conversation

@brickbots

@brickbots brickbots commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Part of #670 (PR 7a in its plan: the corrections files; 7b rebuilds the DB).

This pull request fixes wrong data for about 220 objects in the PiFinder object catalog. Some objects have the wrong size, magnitude, position or type, and some names are on the wrong object. Each fix is a correction: a short entry in a text file that gives the correct value and the published source for it. Some corrections name the star's number in the Hipparcos star catalog, so that the import can find the star when the source's position or magnitude does not agree with it. The import applies all corrections when it builds the object database, and it stops if a correction does not agree with the data. This pull request does not rebuild the database, so users see the changes after the next pull request (7b) rebuilds it.

mrosseel's review: this pull request fixes faults 7 and 8 from his review on #670 (see below).

Detail

This PR adds the corrections #670 and PRs 2–6 left for PR 7, as TOML under astro_data/corrections/: 224 tables in 12 files. It also changes the correction mechanism in two ways: a field correction can clear a magnitude or a size (Rich's decision), and the import now checks a same_as against the loaders' match guard and a size for finite, positive extents (mrosseel's fault 7). The database is not rebuilt or committed here; 7b does that once.

Every table cites its source. Most cite the catalog audit's verdict, with the verdict's why and sources; identifications cite Corwin's position table and notes, and the hip corrections cite the star in SIMBAD. Every was comes from a fresh-file build of 4da2a0a2b, which is main after #693, with this PR's hip corrections applied (see Refreshed after #691, #692 and #693 below).

The mechanism change (its own commit)

When a correction splits a listing off (own_object), the new sky object starts as a copy of the old one. That leaves it holding another object's values, and before this change a correction could not empty a field. So IC 5281, a double star, would have kept NGC 7466's 13.5 mag and 1.5′×0.5′.

  • mag = "" and size = "" now clear the field. As with any field correction, was is required.
  • Clearing a field that is already empty is redundant, and fails the import.
  • obj_type, const and description still cannot be emptied.

The change touches corrections.py, the README, a line in ADR 0046's decision 3, §9.5 of catalog.md, and five new unit tests.

mrosseel's fault 7: gaps in the correction checks (its own commit)

  • Sizes. size = "nan", "inf", "0" and "-5" parsed as floats and passed. A correction's size (and its was.size) must now parse to finite, positive extents. size = "" still clears a size.
  • same_as is checked against the loaders' match guard (match_guard: compatible types, and within 30′ or the target's major axis). The guard uses the listing's own type and position, those of the sky object it leaves, against the sky object it joins, as corrected in the same pass. So Lyn 855 → Col 401 passes once Col 401's Dec is corrected. A same_as the guard rejects fails the import, so ["Lyn 919"] same_as = "NGC 224" no longer passes.
  • guard = false opts out a cited identification whose listing's position or type is wrong. It is valid only with a same_as, needs its why like any table, and is in the README. On a same_as the guard accepts it is redundant, and fails.
  • own_object gets no check. The new sky object starts as a copy of the old one, at the same position and type, so the guard would always pass; any field the split moves carries its own was.
  • ADR 0046 decisions 3 and 6, §9.5 of catalog.md and the README each get a line.

All 17 shipped identifications (14 same_as, 3 own_object) were checked. Four same_as fail the guard, and each is a cited identification with the source's position wrong, so each now has guard = false:

table separation why it is right anyway
Col 208 = IC 2488 42.8′ Collinder names IC 2488 and gives its magnitude and size; its Dec slips 43′
Lyn 866 = NGC 6846 119.9′ Lyngå names NGC 6846 and gives its RA, size and magnitude; its Dec slips 2°
Lyn 639 = Col 285 1,221.9′ one moving group with two centres (Rich's decision, #680)
NGC 6138 = NGC 6363 673.8′ Steinicke's NGC 6138 row is on NGC 6141; Corwin has NGC 6138 = NGC 6363

The other 10 same_as pass the guard (IC 2145, the new one below, included); the 3 own_object are unchecked, as above.

mrosseel's fault 8: IC 2145 (its own commit)

#681 listed IC 2145 2′ → 0.2′ "citing Bica", and the earlier version of this PR set 0.2′ citing Bica. That was wrong: the vendored Bica row NGC2086,IC2145,LMC-N160C gives 0.85′×0.80′. The 0.2′ is SIMBAD's 0.19′ for the cluster, which the audit took from OpenNGC; no source the correction cited gives it.

Corwin identifies IC 2145 with NGC 2086 ("IC 2145 = NGC 2086, which see"), and Bica names both in one row, but PiFinder keeps them as two sky objects 0.97′ apart. So the size correction is replaced by same_as = "NGC 2086", which already holds Bica's 0.85′×0.80′. The audit still flags IC 2145's size against OpenNGC's 0.19′; that finding now compares Bica's nebula with SIMBAD's cluster and stays open.

Files

file tables what it fixes
steinicke.toml 115 Steinicke's errors. 35 types; 34 magnitudes; 48 sizes; 19 positions; NGC 1404's constellation. Also Corwin's identifications: 6 not-found objects identified (their "Not found" description lead removed), 6 same_as (IC 2145 = NGC 2086 among them) and 3 own_object.
sac_multistars.toml 64 45 hip identifications (#692's list plus STF 2576). 16 name fixes: transcription errors, misspellings, two names in one string, and a note stored as a name. Vega, Fomalhaut and ζ Scl typed *.
tlk.toml 14 14 hip identifications. La Superba's V range, 4.86–7.32 (GCVS), replaces TLK's photographic one.
collinder.toml 9 The Decs of Col 401 and Col 394, plus same_as for the Lyngå listings they blocked (Lyn 855, Lyn 829). Col 208 = IC 2488 (guard = false). IC 1590's size, 6′×4′ (Corwin). C 37's magnitude, 5.9. Two two-names-in-one strings.
ngc2000_names.toml 5 The misplaced names: "Bode's Nebulae" off M 82; the Horsehead moved from IC 434 to B 33; "M51" and "Whirlpool Galaxy" off NGC 5195; the truncated "Hubble's Variable Neb" removed.
wds.toml 4 hip identifications: 3 from #692's list, and Gumala (WDS 99456).
sac_redstars.toml 6 hip identifications: 2 from #692's list, and 4 red variables. T Dra and BE CMa also get their GCVS V ranges.
lynga.toml 3 Lyn 919 = NGC 6997, Lyn 866 = NGC 6846 (a 2° Dec slip), and Lyn 639 = Col 285 (Rich's decision); the last two with guard = false.
rasc_doubles.toml 1 hip for RDS 69.
caldwell.toml 1 C 41 = Col 50 (the Hyades).
arp.toml 1 Arp 65 = NGC 90.
taas200.toml 1 "Part of Kemble's Cascade" is a description, not a name.
total 224 70 of them hip

The dry run

Built from a fresh file with these corrections in place. The pass applies all 224, with no stale, redundant, unresolvable or conflicting table, and every same_as passes the match guard or carries a cited guard = false. The star stage merges 2,214 sky objects into 1,789 stars, 70 of them by hip correction. The import takes about 45 s, and the tracked DB was restored afterwards.

Findings (the audit's findings.py, paperChart_dev, read-only)

build findings
main (4da2a0a2b), no corrections 1,135
the 70 hip tables only 1,134 (8 removed, 7 added)
all 224 corrections 1,016

The hip tables join star listings, so star findings move to the joined sky object. Of the 7 added, 3 are the same finding under a new key (42 Ori, 61 Cyg and Mira's magnitude). The other 4 are star_double findings for Zavijava, α Mic, Asterope and Mira: once a hip table joins a SAC double row to its star, the audit compares the D* type with Hipparcos's CCDM. These are the D* rule's outcomes (PR 4), not values this PR writes.

Against the hip-only build, 119 findings are removed and 1 is added:

category removed
size 31
magnitude 21
position 18
kind 14
size_missing 10
star_name_far 8
magnitude_missing 7
constellation 3
star_double 3
name_catalog_only 2
name 1
star_magnitude 1

The one added is La Superba: the audit compares its GCVS V range, 4.86–7.32, with Hipparcos's single V of 5.42, which lies inside that range. IC 2145's size finding stays open (fault 8), at Bica's 0.85′ against OpenNGC's 0.19′. The remaining type findings for the status-6 HII regions and similar objects had already disappeared in PR 3, because a ? or Ast isn't drawn, so their corrections don't show here.

Coverage

Every item the plan assigned to PR 7, with the correction that settles it or the reason there is none.

item outcome
#670 item 9: Corwin's identifications for not-found objects IC 346, IC 3056, IC 4991, NGC 4323, NGC 6847: position, type, size and description (NGC 4323 also takes Steinicke's V 13.9 from his NGC 4322 row = UGC 7450; NGC 6847 is C+N, Rich's decision). IC 2477 same_as IC 2480, with its description. NGC 3355 is unresolved.
item 10: M 43 9.0, M 78 8.3, M 8 6.0, NGC 2070 8.0, IC 1266 11.4 steinicke.toml
item 11, identifications IC 919, IC 4494, NGC 6174, NGC 4230, NGC 6625, NGC 2244 positions; IC 998 moved, its copied values cleared; IC 997 own_object with the pair's values from Steinicke's IC 998 row (PGC 51220); IC 1795 own_object; IC 5281 own_object, D*, cleared; NGC 4362 same_as NGC 4364; NGC 4322 a star (Corwin, firm), cleared. NGC 553: Corwin's identification is only probable, so no change. NGC 6002: unresolved, no change.
item 11, types NGC 2244, 2579, 3247, IC 2128, NGC 1921 → C+N; NGC 1839, 361, 2034, 1943 → OC
item 11, magnitudes NGC 4872 14.4 and NGC 4874 11.7, with positions and sizes (Steinicke's two rows are swapped); 15 galaxies off by 0.5–1.9 (§D of the audit's report); the LMC "9.p" values NGC 1814, 1816, 1820, 1974, plus NGC 1938 and 1847
item 11, sizes 12 MCG inner diameters; 7 compact planetaries; NGC 602, 395, 1869 (IC 2145 is a same_as instead: fault 8); the cores NGC 1986, 2016, 2027, 2037, 2041 (Bica); IC 424 2.5′; IC 1995 60′×30′; NGC 6526 40′; NGC 2455, 2579, 6605, 6625
item 11, missing sizes IC 1590 is a Collinder correction (collinder.toml); IC 1871, NGC 2246 and NGC 6847 are in steinicke.toml. NGC 1931 is redundant now: Collinder fills 4′×4′.
item 11, NGC 1404 const = "Eri"
item 18: Fomalhaut and ζ Scl * sac_multistars.toml (with Vega, below)
item 19, SAC names SaM 307, 1709, 1348, 2003, 853, 860, 835, 1165, 1771/1772 and 1773 ("Lesath" and "Laseth" removed; the WGSN source makes Jabbah preferred), 1440, 587, 1252
item 19: α Mic and ξ Lup hip SaM 1297 → 102831, SaM 1211 → 78105
item 24, ngc2000_names.toml M 82: removal only, since "Cigar Galaxy" is already first from messier_names.dat. IC 434 / B 33. NGC 5195. NGC 2261: removal only, since "Hubble's Variable Nebula" is already there from Caldwell. NGC 651: none, since it now shares M 76's sky object, where its names belong, and a removal would strip them from M 76.
item 25, two names or a description "Owl or E.T. Cluster" and "Theta Carinae Cluster, Southern Pleiades" (collinder.toml); "Al Rischa (Alrescha)" → Alrescha and "Burnham pm" (sac_multistars.toml); "Part of Kemble's Cascade" (taas200.toml)
item 14: La Superba tlk.toml, mag [4.86, 7.32]
#676: M 18, IC 1311 → OC; IC 4685 → Nb steinicke.toml
#676: the 13 status-6 types NGC 5447 (and NGC 5450 through it), 5449, 5451, 5453, 5455, 5461, 5462, 5471, IC 1308, IC 3551, NGC 3181 → Nb; NGC 206 → OC; IC 142 → Nb
#676: NGC 5120, 5299, 6682 → OC steinicke.toml
#676: duplicate twins Corwin decides differently NGC 4362, IC 1795, IC 5281 and IC 997/IC 4401, as above
#676: the 15 unchecked twins Checked against Corwin. He agrees with Steinicke or is undecided on 12, so there is no change: IC 312, IC 936 (an Abell 1783 puzzle Corwin leaves open), IC 1760, IC 1799, NGC 241, 758 (Corwin "=?"), 1226, 1677, 1911, 2789, 3609, 6191 (Corwin "=?"). NGC 2226: Corwin calls it NGC 2225's compact core, so no change. IC 4763 same_as NGC 6679 (Corwin). NGC 6141: Steinicke's NGC 6138 row sits on Corwin's NGC 6141, and Corwin has NGC 6138 = NGC 6363, so NGC 6138 is moved by same_as NGC 6363.
#676: the four duplicates kept apart IC 1028 same_as NGC 5739 (Corwin). No change for IC 2458 (Corwin: an HII region in NGC 2820, at its own position) or IC 820 (= NGC 4676B, which PiFinder doesn't list). NGC 6363 now carries NGC 6138.
#676: NGC 651 see item 24
#676: NGC 2244 type and position on the shared NGC 2244/2239 sky object
#675: C 37 V 5.9 collinder.toml (Col 417), with Corwin's centre in steinicke.toml
#675: C 41, Lyn 919, Arp 65 same_as as planned
#675: Lyn 866 same_as NGC 6846 (SIMBAD +32 20 56; Lyngå's +30 21 is a slip)
#675: Col 208 same_as IC 2488 with guard = false: Collinder's own aka, magnitude and size agree, and its Dec is 43′ off
#675: NGC 6222 none. Corwin has NGC 6222 = NGC 6259, as Steinicke does, so Collinder's "NGC 6222" on Col 314 is wrong and the guard was right to refuse it.
#675: NGC 7429's 15′ none: no verdict, and SIMBAD has no optical size to cite
#675: IC 1590, NGC 1931 sizes IC 1590 corrected; NGC 1931 redundant
#680: Col 401, Col 394 Decs from SIMBAD. Lyn 855 and Lyn 829 also need same_as: corrections apply after the loaders, so fixing the position alone would not make them join.
#680: Lyn 639 / Col 285 same_as (Rich's decision)
#681: NGC 7513 V 11.9 steinicke.toml (Rich's decision)
#681: NGC 2029 / NGC 2030 Steinicke agrees with Corwin; Bica's rows carry ESO's swapped names, which Corwin documents. Sizes by position: 1.7′×1.7′ and 1.1′×0.85′.
#681: NGC 2094 none. Steinicke is Corwin's; Bica's is SL 659, 33′ south, a mistake Corwin documents.
#681: NGC 2171 none: Corwin finds nothing at JH's position
#681: NGC 1932 none: Corwin says an asterism; Steinicke *
#681: IC 2115 none: Corwin rules out = NGC 1763
#681: IC 2116 none: Corwin's Neb*, Steinicke *
#681: NGC 1911 none: Corwin has = NGC 1920 (probable), as Steinicke does
#681: NGC 1915 unresolved: Corwin is undecided between an association and NGC 1919
#681: NGC 1921 C+N; size unresolved (Bica has its components only)
#681: Bica-cited sizes NGC 602, 395, 1869 and the five cores, each checked against the vendored Bica rows. IC 2145: same_as NGC 2086 instead (fault 8).
#683: Vega, Fomalhaut, ζ Scl * sac_multistars.toml
#683: STF 2576 (SaM 693) hip = 97222. SIMBAD lists HD 186858 = HIP 97222 as ** STF 2576AB.
#683: the 22 wrong 3–6′ matches none needed (they no longer match)
#685: the 84 hip corrections replaced by #692's 64, by source, with #692's evidence as why
#691: 5 SAC red variables T Dra, BE CMa, Z Lup, NY Gem: hip; T Dra and BE CMa also get their GCVS V ranges. BE CMi: none (see below).
#677: M 82 the removal only
#677: title-cased names used throughout ngc2000_names.toml
brief: "Menkib" on ξ Peg removed (SaM 1521)
brief: SaM 1772's "Laseth" removed with SaM 1771's table (same sky object); SaM 1773, which #692 splits off, has its own table
brief: M 24's position none (Rich's decision, #677)

Also no correction:

  • The 10 RC3-replaced galaxies within 0.2 mag of the audit's value (IC 1796, IC 1864, IC 4731, NGC 484, 862, 4277, 5121, 5397, 6725, 6808). The RC3 supplementary source settles them.
  • The five globulars (Harris).
  • The Magellanic objects Bica now fills.
  • The Arp lettered sizes (PR 2).

Left uncorrected (Rich's decision)

None of these has a value that a source we can cite gives, so this PR does not correct them. They stay as follow-ups.

  1. NGC 3355, NGC 6002, NGC 553, IC 374, NGC 2319, IC 337, IC 1831 and NGC 7287 are unresolved by Catalog import: fix the types, names, positions, magnitudes and sizes the 2026-10 audit found #670's decision.
  2. NGC 1915's identification (Corwin is undecided).
  3. NGC 1921's size: Bica gives its components only.
  4. NGC 2094's size: Corwin says "just over half an arcminute", which is not a value to cite.
  5. IC 2599 (about 8′, "no measured size"), NGC 6647 (about 7′; Corwin says the size is unknown) and NGC 595 (about 1.1′, derived from a radius): the audit's values are estimates, and none is in Catalog import: fix the types, names, positions, magnitudes and sizes the 2026-10 audit found #670's list.
  6. The audit's 26 catalog_missing NGC/IC names (Bow-Tie Nebula, Jellyfish Nebula, Cave Nebula on C 9…). No published source PiFinder vendors has them wrong; they are missing. Adding them is the names work Catalog import: fix the types, names, positions, magnitudes and sizes the 2026-10 audit found #670 puts out of scope.
  7. C 9's position: the audit prefers caldwell.dat's to Sharpless's, but it isn't in Catalog import: fix the types, names, positions, magnitudes and sizes the 2026-10 audit found #670's list.

That is 15 items, all left as they are.

Refreshed after #691, #692 and #693

This branch merges main (4da2a0a2b) with no conflicts. The tables changed as follows: 238 → 224.

Left, and follow-ups:

  • Gumala's companion. After the join, Gumala shows [6.25, 10.1]: Hipparcos's V for the primary, but WDS's K magnitude for the companion. This is a known limit; this PR adds no correction for it.
  • NGC 771 = 50 Cas (Corwin's NGC notes: "NGC 771 = 50 Cassiopeiae is a star"). No other catalog lists 50 Cas yet, so there is nothing to join. After feat(catalogs): a Named Stars catalog of every IAU-named star, numbered by Hipparcos #695 merges, the follow-up is a same_as to its Named Stars listing for HIP 9598.

Testing

  • Unit tests in tests/test_catalog_corrections.py:
    • five cover clearing a magnitude and a size, a redundant clear, and the fields that can't be emptied;
    • for fault 7, nine new rejection cases (nan, inf, -5, 0 and a negative axis in a size, was.size = "nan", guard = true, a non-boolean guard, and guard without a same_as) and five new tests: a far same_as fails, an incompatible type fails, guard = false lets a far one through, a redundant guard = false fails, and the guard sees the target as corrected;
    • three existing identification tests now use fixture objects near their targets (M 43 next to M 42, a galaxy next to NGC 7466), since the guard refuses their old far targets.
    • test_shipped_corrections_load passes with these files.
  • nox: lint, format, type_hints, smoke_tests (5) and unit_tests (2,194) all pass.
  • DB: fresh-file dry run as above. The DB is not committed (7b).

🤖 Generated with Claude Code

brickbots and others added 6 commits November 8, 2026 19:35
…miss

One table per designator, in the file of the source it lists: SAC's
doubles and red stars, TLK, RASC's doubles and WDS. Each cites the
Hipparcos star in SIMBAD and gives #685's evidence as its why. A dry
run applies all 84: 2,261 sky objects merge into 1,795 stars.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngå's and SAC's errors

The corrections #670 and PRs 2-6 left for PR 7: Steinicke's types,
magnitudes, sizes and Corwin's identifications; NGC 2000.0's misplaced
names; Collinder's positions and sizes; Lyngå's, Caldwell's and Arp's
identifications; SAC's misnamed rows and star types; La Superba's
range. Each cites the audit's verdict or Corwin. A dry run applies all
of them.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r a size

A split copies its old sky object's values, and a moved identification
can leave a sky object holding another object's magnitude and size,
with no source that gives its own: IC 5281, a double star, would keep
NGC 7466's. `mag = ""` and `size = ""` clear them, with `was`
required as for any field correction; clearing a field that is already
empty is redundant and fails. Rich's decision.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NGC 4322 is Corwin's star, with the galaxy's magnitude and size cleared
and V 13.9 moved to NGC 4323; IC 5281's and IC 998's copied values are
cleared, and IC 997 takes the pair's from Steinicke's IC 998 row.
NGC 6847 is C+N. Col 208 joins IC 2488 (Collinder's own
identification), NGC 2029 and NGC 2030 take the Bica sizes at their
positions, and STF 2576 is HIP 97222. The not-found objects Corwin
identifies drop Steinicke's not-found lead from their descriptions.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd a size for finite, positive extents

mrosseel's fault 7 on #670 (#672's correction checks):

- A correction's size must parse to finite, positive extents. "nan",
  "inf", "0" and "-5" parsed as floats and passed strict parsing. The
  empty size = "" still clears a size.
- A same_as must pass the loaders' match guard, from the listing's own
  type and position (those of the sky object it leaves) to the sky object
  it joins, as corrected in the same pass. Before, ["Lyn 919"] same_as =
  "NGC 224" passed at 100 degrees from the listing.
- guard = false opts out a cited identification whose listing's position
  or type is wrong. It is valid only with a same_as, and on a same_as the
  guard accepts it is redundant and fails.
- own_object gets no guard: its new sky object starts at the old
  position, and any field it moves carries its own was.

Four shipped same_as fail the guard, each a cited identification with
the source's position wrong, and now carry guard = false: Col 208 =
IC 2488 (Collinder's Dec slip, 43'), Lyn 866 = NGC 6846 (Lynga's Dec
slip, 2 degrees), Lyn 639 = Col 285 (one moving group with two centres,
Rich's decision on #680), and NGC 6138 = NGC 6363 (Steinicke's row is on
NGC 6141, 11 degrees away; Corwin).

ADR 0046 decisions 3 and 6, catalog.md 9.5 and the corrections README
say so.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mrosseel's fault 8 on #670: #681 listed IC 2145 2' -> 0.2' citing Bica,
but the vendored Bica row NGC2086,IC2145,LMC-N160C gives 0.85'x0.80'.
The 0.2' is SIMBAD's 0.19' for the cluster, which the audit carried
over from OpenNGC; no source this correction cites gives it.

Corwin identifies IC 2145 with NGC 2086, and Bica names both in one row.
PiFinder keeps them as two sky objects 0.97' apart, so the size
correction becomes same_as = "NGC 2086", which already holds Bica's
0.85'x0.80'.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #691 (Hipparcos values, IAU WGSN names), #692 (star matching
on independent evidence) and #693 (designations.py). No textual
conflicts: catalog_import_utils.py, test_catalog_corrections.py and
docs/ax/catalog.md merged cleanly.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brickbots and others added 2 commits November 9, 2026 21:35
#692's star matching replaces the 85 hip corrections with its list
of 64, judged on independent evidence. SaM 693 (STF 2576 = HIP 97222),
this PR's own addition, is kept: no rule finds it. 20 fewer tables.

Every was is refreshed against a build of main (4da2a0a) with the
hip corrections. One value moved: La Superba's magnitude, now
Hipparcos's V 5.42 (#691) instead of SAC's 4.8.

#691's WGSN names make four name parts redundant: SaM 1771's preferred
Jabbah, and the added Hatysa, Asellus Australis and Alrescha. The
tables keep their removals of SAC's misspellings.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…3's Laseth

#692's V gate on rule 1 leaves five SAC red variables unmatched (#691's
"Left for PR 7"). Four rows name an HD or BD number that SIMBAD gives
as their Hipparcos star, so each gets a hip correction:

- T Dra (SaR 139) = HIP 87820, with its GCVS V range [7.2, 13.5];
- BE CMa (SaR 96) = HIP 35865, with its GCVS V range [8.6, 9.4];
- Z Lup (SaR 187) = HIP 71386 and NY Gem (SaR 155) = HIP 31829, which
  take Hipparcos's V through #691 (GCVS gives photographic ranges only).

BE CMi (SaR 98) is left: SIMBAD has HIP 37022 as another star, 46"
away, and SAC's 8.7 lies inside its GCVS V range.

WDS 99456 (LLO 18) is HIP 94645, Gumala: 1.4" from it, and WDS's note
K marks its 4.94 as a K-band magnitude, so the V gate refused it.

#692 split SaM 1773 (nu Sco's CD row) off the system, so SaM 1771's
removal of the misspelled 'Laseth' no longer reached it. SaM 1773 now
has its own removal.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@brickbots brickbots changed the title fix(catalog-corrections): cited corrections for about 240 objects, and stricter correction checks fix(catalog-corrections): cited corrections for about 220 objects, and stricter correction checks Nov 10, 2026
@brickbots
brickbots marked this pull request as ready for review November 10, 2026 04:37
@brickbots
brickbots merged commit 9cb588a into main Nov 10, 2026
4 checks passed
@brickbots
brickbots deleted the fix/catalog-corrections-data branch November 10, 2026 05:12
Zhuohang-Shen pushed a commit to Zhuohang-Shen/PiFinder that referenced this pull request Nov 15, 2026
Brings in 24 commits of brickbots main: the catalog import fixes
(brickbots#671 to brickbots#694), the Named Stars catalog (brickbots#695), the names view of the
object list (brickbots#696), the Pi OS side of the migration (brickbots#657), the release
workflow (brickbots#658), the OLED SPI clock (brickbots#701) and CI changes.

Conflicts and their resolution:
- Pi OS migration files (migration_gate.json, migration_progress,
  migration_progress.c, nixos_migration_calc.py): nixos keeps them
  deleted. They belong to the Pi OS line.
- noxfile.py, requirements_dev.txt: nixos keeps them deleted. The flake
  dev shell and uv2nix replace them.
- ui/software.py, tests/test_software.py, sys_utils.py, main.py: nixos
  keeps its own software screen. Its keep_awake and on_battery are the
  same feature as upstream's. The migration UI stays out of nixos.
- catalog_imports: upstream's code. The parser moved to designations.py,
  so the local copy of parse_designation goes. The Perek-Kohoutek loader
  stays and runs before the Named Stars loader.
- catalogs.py: upstream's NAME_MODE_CATALOGS. The T9 tables stay in
  catalog_arrays.py.
- object_details.py: upstream's listing index (brickbots#678), with a search on
  the listing_key column for an ObjectSequence.
- obslist.py and its tests: the name index of nixos (resolvers) with
  upstream's ambiguous designation check.
- tests/test_ui_modules.py: upstream's comet retry stub, the catalog
  build of nixos (no background loader).
- docs/ax/catalog.md, CONTEXT.md: text of both sides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zhuohang-Shen pushed a commit to Zhuohang-Shen/PiFinder that referenced this pull request Nov 15, 2026
…fixes

The committed database was built before the catalog import changes of
upstream main. It now holds the Named Stars catalog (578 stars) and the
import fixes (brickbots#681, brickbots#683, brickbots#685, brickbots#691, brickbots#692, brickbots#694, brickbots#695). EGC has 102
objects (was 91) and SaM 2157 (was 2162). IC 1805 is now one object with
Sh2 190 and Lyn 77, of type cluster with nebula. The catalog data test
has the new values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant