Repository navigation
fix(catalog-corrections): cited corrections for about 220 objects, and stricter correction checks - #694
Merged
Conversation
…miss One table per designator, in the file of the source it lists: SAC's doubles and red stars, TLK, RASC's doubles and WDS. Each cites the Hipparcos star in SIMBAD and gives #685's evidence as its why. A dry run applies all 84: 2,261 sky objects merge into 1,795 stars. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngå's and SAC's errors The corrections #670 and PRs 2-6 left for PR 7: Steinicke's types, magnitudes, sizes and Corwin's identifications; NGC 2000.0's misplaced names; Collinder's positions and sizes; Lyngå's, Caldwell's and Arp's identifications; SAC's misnamed rows and star types; La Superba's range. Each cites the audit's verdict or Corwin. A dry run applies all of them. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r a size A split copies its old sky object's values, and a moved identification can leave a sky object holding another object's magnitude and size, with no source that gives its own: IC 5281, a double star, would keep NGC 7466's. `mag = ""` and `size = ""` clear them, with `was` required as for any field correction; clearing a field that is already empty is redundant and fails. Rich's decision. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NGC 4322 is Corwin's star, with the galaxy's magnitude and size cleared and V 13.9 moved to NGC 4323; IC 5281's and IC 998's copied values are cleared, and IC 997 takes the pair's from Steinicke's IC 998 row. NGC 6847 is C+N. Col 208 joins IC 2488 (Collinder's own identification), NGC 2029 and NGC 2030 take the Bica sizes at their positions, and STF 2576 is HIP 97222. The not-found objects Corwin identifies drop Steinicke's not-found lead from their descriptions. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd a size for finite, positive extents mrosseel's fault 7 on #670 (#672's correction checks): - A correction's size must parse to finite, positive extents. "nan", "inf", "0" and "-5" parsed as floats and passed strict parsing. The empty size = "" still clears a size. - A same_as must pass the loaders' match guard, from the listing's own type and position (those of the sky object it leaves) to the sky object it joins, as corrected in the same pass. Before, ["Lyn 919"] same_as = "NGC 224" passed at 100 degrees from the listing. - guard = false opts out a cited identification whose listing's position or type is wrong. It is valid only with a same_as, and on a same_as the guard accepts it is redundant and fails. - own_object gets no guard: its new sky object starts at the old position, and any field it moves carries its own was. Four shipped same_as fail the guard, each a cited identification with the source's position wrong, and now carry guard = false: Col 208 = IC 2488 (Collinder's Dec slip, 43'), Lyn 866 = NGC 6846 (Lynga's Dec slip, 2 degrees), Lyn 639 = Col 285 (one moving group with two centres, Rich's decision on #680), and NGC 6138 = NGC 6363 (Steinicke's row is on NGC 6141, 11 degrees away; Corwin). ADR 0046 decisions 3 and 6, catalog.md 9.5 and the corrections README say so. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mrosseel's fault 8 on #670: #681 listed IC 2145 2' -> 0.2' citing Bica, but the vendored Bica row NGC2086,IC2145,LMC-N160C gives 0.85'x0.80'. The 0.2' is SIMBAD's 0.19' for the cluster, which the audit carried over from OpenNGC; no source this correction cites gives it. Corwin identifies IC 2145 with NGC 2086, and Bica names both in one row. PiFinder keeps them as two sky objects 0.97' apart, so the size correction becomes same_as = "NGC 2086", which already holds Bica's 0.85'x0.80'. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #691 (Hipparcos values, IAU WGSN names), #692 (star matching on independent evidence) and #693 (designations.py). No textual conflicts: catalog_import_utils.py, test_catalog_corrections.py and docs/ax/catalog.md merged cleanly. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#692's star matching replaces the 85 hip corrections with its list of 64, judged on independent evidence. SaM 693 (STF 2576 = HIP 97222), this PR's own addition, is kept: no rule finds it. 20 fewer tables. Every was is refreshed against a build of main (4da2a0a) with the hip corrections. One value moved: La Superba's magnitude, now Hipparcos's V 5.42 (#691) instead of SAC's 4.8. #691's WGSN names make four name parts redundant: SaM 1771's preferred Jabbah, and the added Hatysa, Asellus Australis and Alrescha. The tables keep their removals of SAC's misspellings. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…3's Laseth #692's V gate on rule 1 leaves five SAC red variables unmatched (#691's "Left for PR 7"). Four rows name an HD or BD number that SIMBAD gives as their Hipparcos star, so each gets a hip correction: - T Dra (SaR 139) = HIP 87820, with its GCVS V range [7.2, 13.5]; - BE CMa (SaR 96) = HIP 35865, with its GCVS V range [8.6, 9.4]; - Z Lup (SaR 187) = HIP 71386 and NY Gem (SaR 155) = HIP 31829, which take Hipparcos's V through #691 (GCVS gives photographic ranges only). BE CMi (SaR 98) is left: SIMBAD has HIP 37022 as another star, 46" away, and SAC's 8.7 lies inside its GCVS V range. WDS 99456 (LLO 18) is HIP 94645, Gumala: 1.4" from it, and WDS's note K marks its 4.94 as a K-band magnitude, so the V gate refused it. #692 split SaM 1773 (nu Sco's CD row) off the system, so SaM 1771's removal of the misspelled 'Laseth' no longer reached it. SaM 1773 now has its own removal. Refs #670 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brickbots
marked this pull request as ready for review
November 10, 2026 04:37
15 tasks done
Zhuohang-Shen
pushed a commit
to Zhuohang-Shen/PiFinder
that referenced
this pull request
Nov 15, 2026
Brings in 24 commits of brickbots main: the catalog import fixes (brickbots#671 to brickbots#694), the Named Stars catalog (brickbots#695), the names view of the object list (brickbots#696), the Pi OS side of the migration (brickbots#657), the release workflow (brickbots#658), the OLED SPI clock (brickbots#701) and CI changes. Conflicts and their resolution: - Pi OS migration files (migration_gate.json, migration_progress, migration_progress.c, nixos_migration_calc.py): nixos keeps them deleted. They belong to the Pi OS line. - noxfile.py, requirements_dev.txt: nixos keeps them deleted. The flake dev shell and uv2nix replace them. - ui/software.py, tests/test_software.py, sys_utils.py, main.py: nixos keeps its own software screen. Its keep_awake and on_battery are the same feature as upstream's. The migration UI stays out of nixos. - catalog_imports: upstream's code. The parser moved to designations.py, so the local copy of parse_designation goes. The Perek-Kohoutek loader stays and runs before the Named Stars loader. - catalogs.py: upstream's NAME_MODE_CATALOGS. The T9 tables stay in catalog_arrays.py. - object_details.py: upstream's listing index (brickbots#678), with a search on the listing_key column for an ObjectSequence. - obslist.py and its tests: the name index of nixos (resolvers) with upstream's ambiguous designation check. - tests/test_ui_modules.py: upstream's comet retry stub, the catalog build of nixos (no background loader). - docs/ax/catalog.md, CONTEXT.md: text of both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zhuohang-Shen
pushed a commit
to Zhuohang-Shen/PiFinder
that referenced
this pull request
Nov 15, 2026
…fixes The committed database was built before the catalog import changes of upstream main. It now holds the Named Stars catalog (578 stars) and the import fixes (brickbots#681, brickbots#683, brickbots#685, brickbots#691, brickbots#692, brickbots#694, brickbots#695). EGC has 102 objects (was 91) and SaM 2157 (was 2162). IC 1805 is now one object with Sh2 190 and Lyn 77, of type cluster with nebula. The catalog data test has the new values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #670 (PR 7a in its plan: the corrections files; 7b rebuilds the DB).
This pull request fixes wrong data for about 220 objects in the PiFinder object catalog. Some objects have the wrong size, magnitude, position or type, and some names are on the wrong object. Each fix is a correction: a short entry in a text file that gives the correct value and the published source for it. Some corrections name the star's number in the Hipparcos star catalog, so that the import can find the star when the source's position or magnitude does not agree with it. The import applies all corrections when it builds the object database, and it stops if a correction does not agree with the data. This pull request does not rebuild the database, so users see the changes after the next pull request (7b) rebuilds it.
mrosseel's review: this pull request fixes faults 7 and 8 from his review on #670 (see below).
Detail
This PR adds the corrections #670 and PRs 2–6 left for PR 7, as TOML under
astro_data/corrections/: 224 tables in 12 files. It also changes the correction mechanism in two ways: a field correction can clear a magnitude or a size (Rich's decision), and the import now checks asame_asagainst the loaders' match guard and a size for finite, positive extents (mrosseel's fault 7). The database is not rebuilt or committed here; 7b does that once.Every table cites its source. Most cite the catalog audit's verdict, with the verdict's
whyandsources; identifications cite Corwin's position table and notes, and thehipcorrections cite the star in SIMBAD. Everywascomes from a fresh-file build of4da2a0a2b, which is main after #693, with this PR'shipcorrections applied (see Refreshed after #691, #692 and #693 below).The mechanism change (its own commit)
When a correction splits a listing off (
own_object), the new sky object starts as a copy of the old one. That leaves it holding another object's values, and before this change a correction could not empty a field. So IC 5281, a double star, would have kept NGC 7466's 13.5 mag and 1.5′×0.5′.mag = ""andsize = ""now clear the field. As with any field correction,wasis required.obj_type,constanddescriptionstill cannot be emptied.The change touches
corrections.py, the README, a line in ADR 0046's decision 3, §9.5 ofcatalog.md, and five new unit tests.mrosseel's fault 7: gaps in the correction checks (its own commit)
size = "nan","inf","0"and"-5"parsed as floats and passed. A correction's size (and itswas.size) must now parse to finite, positive extents.size = ""still clears a size.same_asis checked against the loaders' match guard (match_guard: compatible types, and within 30′ or the target's major axis). The guard uses the listing's own type and position, those of the sky object it leaves, against the sky object it joins, as corrected in the same pass. So Lyn 855 → Col 401 passes once Col 401's Dec is corrected. Asame_asthe guard rejects fails the import, so["Lyn 919"] same_as = "NGC 224"no longer passes.guard = falseopts out a cited identification whose listing's position or type is wrong. It is valid only with asame_as, needs itswhylike any table, and is in the README. On asame_asthe guard accepts it is redundant, and fails.own_objectgets no check. The new sky object starts as a copy of the old one, at the same position and type, so the guard would always pass; any field the split moves carries its ownwas.catalog.mdand the README each get a line.All 17 shipped identifications (14
same_as, 3own_object) were checked. Foursame_asfail the guard, and each is a cited identification with the source's position wrong, so each now hasguard = false:The other 10
same_aspass the guard (IC 2145, the new one below, included); the 3own_objectare unchecked, as above.mrosseel's fault 8: IC 2145 (its own commit)
#681 listed IC 2145 2′ → 0.2′ "citing Bica", and the earlier version of this PR set 0.2′ citing Bica. That was wrong: the vendored Bica row
NGC2086,IC2145,LMC-N160Cgives 0.85′×0.80′. The 0.2′ is SIMBAD's 0.19′ for the cluster, which the audit took from OpenNGC; no source the correction cited gives it.Corwin identifies IC 2145 with NGC 2086 ("IC 2145 = NGC 2086, which see"), and Bica names both in one row, but PiFinder keeps them as two sky objects 0.97′ apart. So the size correction is replaced by
same_as = "NGC 2086", which already holds Bica's 0.85′×0.80′. The audit still flags IC 2145's size against OpenNGC's 0.19′; that finding now compares Bica's nebula with SIMBAD's cluster and stays open.Files
steinicke.tomlsame_as(IC 2145 = NGC 2086 among them) and 3own_object.sac_multistars.tomlhipidentifications (#692's list plus STF 2576). 16 name fixes: transcription errors, misspellings, two names in one string, and a note stored as a name. Vega, Fomalhaut and ζ Scl typed*.tlk.tomlhipidentifications. La Superba's V range, 4.86–7.32 (GCVS), replaces TLK's photographic one.collinder.tomlsame_asfor the Lyngå listings they blocked (Lyn 855, Lyn 829). Col 208 = IC 2488 (guard = false). IC 1590's size, 6′×4′ (Corwin). C 37's magnitude, 5.9. Two two-names-in-one strings.ngc2000_names.tomlwds.tomlhipidentifications: 3 from #692's list, and Gumala (WDS 99456).sac_redstars.tomlhipidentifications: 2 from #692's list, and 4 red variables. T Dra and BE CMa also get their GCVS V ranges.lynga.tomlguard = false.rasc_doubles.tomlhipfor RDS 69.caldwell.tomlarp.tomltaas200.tomlhipThe dry run
Built from a fresh file with these corrections in place. The pass applies all 224, with no stale, redundant, unresolvable or conflicting table, and every
same_aspasses the match guard or carries a citedguard = false. The star stage merges 2,214 sky objects into 1,789 stars, 70 of them byhipcorrection. The import takes about 45 s, and the tracked DB was restored afterwards.Findings (the audit's
findings.py, paperChart_dev, read-only)4da2a0a2b), no correctionshiptables onlyThe
hiptables join star listings, so star findings move to the joined sky object. Of the 7 added, 3 are the same finding under a new key (42 Ori, 61 Cyg and Mira's magnitude). The other 4 arestar_doublefindings for Zavijava, α Mic, Asterope and Mira: once ahiptable joins a SAC double row to its star, the audit compares the D* type with Hipparcos's CCDM. These are the D* rule's outcomes (PR 4), not values this PR writes.Against the hip-only build, 119 findings are removed and 1 is added:
The one added is La Superba: the audit compares its GCVS V range, 4.86–7.32, with Hipparcos's single V of 5.42, which lies inside that range. IC 2145's size finding stays open (fault 8), at Bica's 0.85′ against OpenNGC's 0.19′. The remaining type findings for the status-6 HII regions and similar objects had already disappeared in PR 3, because a
?orAstisn't drawn, so their corrections don't show here.Coverage
Every item the plan assigned to PR 7, with the correction that settles it or the reason there is none.
C+N, Rich's decision). IC 2477same_asIC 2480, with its description. NGC 3355 is unresolved.steinicke.tomlown_objectwith the pair's values from Steinicke's IC 998 row (PGC 51220); IC 1795own_object; IC 5281own_object,D*, cleared; NGC 4362same_asNGC 4364; NGC 4322 a star (Corwin, firm), cleared. NGC 553: Corwin's identification is only probable, so no change. NGC 6002: unresolved, no change.C+N; NGC 1839, 361, 2034, 1943 →OCsame_asinstead: fault 8); the cores NGC 1986, 2016, 2027, 2037, 2041 (Bica); IC 424 2.5′; IC 1995 60′×30′; NGC 6526 40′; NGC 2455, 2579, 6605, 6625collinder.toml); IC 1871, NGC 2246 and NGC 6847 are insteinicke.toml. NGC 1931 is redundant now: Collinder fills 4′×4′.const = "Eri"*sac_multistars.toml(with Vega, below)hipngc2000_names.tomlmessier_names.dat. IC 434 / B 33. NGC 5195. NGC 2261: removal only, since "Hubble's Variable Nebula" is already there from Caldwell. NGC 651: none, since it now shares M 76's sky object, where its names belong, and a removal would strip them from M 76.collinder.toml); "Al Rischa (Alrescha)" → Alrescha and "Burnham pm" (sac_multistars.toml); "Part of Kemble's Cascade" (taas200.toml)tlk.toml, mag [4.86, 7.32]OC; IC 4685 →Nbsteinicke.tomlNb; NGC 206 →OC; IC 142 →NbOCsteinicke.tomlsame_asNGC 6679 (Corwin). NGC 6141: Steinicke's NGC 6138 row sits on Corwin's NGC 6141, and Corwin has NGC 6138 = NGC 6363, so NGC 6138 is moved bysame_asNGC 6363.same_asNGC 5739 (Corwin). No change for IC 2458 (Corwin: an HII region in NGC 2820, at its own position) or IC 820 (= NGC 4676B, which PiFinder doesn't list). NGC 6363 now carries NGC 6138.collinder.toml(Col 417), with Corwin's centre insteinicke.tomlsame_assame_asNGC 6846 (SIMBAD +32 20 56; Lyngå's +30 21 is a slip)same_asIC 2488 withguard = false: Collinder's own aka, magnitude and size agree, and its Dec is 43′ offsame_as: corrections apply after the loaders, so fixing the position alone would not make them join.same_as(Rich's decision)steinicke.toml(Rich's decision)**C+N; size unresolved (Bica has its components only)same_asNGC 2086 instead (fault 8).*sac_multistars.tomlhip = 97222. SIMBAD lists HD 186858 = HIP 97222 as ** STF 2576AB.hipcorrectionswhyhip; T Dra and BE CMa also get their GCVS V ranges. BE CMi: none (see below).ngc2000_names.tomlAlso no correction:
Left uncorrected (Rich's decision)
None of these has a value that a source we can cite gives, so this PR does not correct them. They stay as follow-ups.
catalog_missingNGC/IC names (Bow-Tie Nebula, Jellyfish Nebula, Cave Nebula on C 9…). No published source PiFinder vendors has them wrong; they are missing. Adding them is the names work Catalog import: fix the types, names, positions, magnitudes and sizes the 2026-10 audit found #670 puts out of scope.That is 15 items, all left as they are.
Refreshed after #691, #692 and #693
This branch merges main (
4da2a0a2b) with no conflicts. The tables changed as follows: 238 → 224.hip: 85 → 70. fix(catalog): filter a double star by its brightest magnitude, and match stars only on independent evidence #692's list of 64 replaces fix(catalog-import): identify stars by the exact identifiers they share with Hipparcos and WDS #685's 84. SaM 693 (STF 2576), this PR's own table, stays: no rule finds it.was: one value moved. La Superba's (TLK 19)was.magwent from 4.8 to 5.42 because fix(catalog-import): star positions, brightness and IAU names from Hipparcos and the WGSN #691 sets Hipparcos's V on it. Its corrected range, [4.86, 7.32], is unchanged.Names: four parts were redundant, because fix(catalog-import): star positions, brightness and IAU names from Hipparcos and the WGSN #691's WGSN source now gives these names:
names.preferred = "Jabbah";names.addof Hatysa (SaM 1440), Asellus Australis (SaM 587) and Alrescha (SaM 1667).Each of these tables keeps its removal of SAC's misspelling.
SaM 1773's "Laseth": a new table. fix(catalog): filter a double star by its brightest magnitude, and match stars only on independent evidence #692 splits ν Sco's CD row off the system, so SaM 1771's removal no longer reaches it.
The red variables of fix(catalog-import): star positions, brightness and IAU names from Hipparcos and the WGSN #691's "Left for PR 7". fix(catalog): filter a double star by its brightest magnitude, and match stars only on independent evidence #692's V gate on rule 1 leaves all five unmatched. Each row names an HD or BD number, which was checked against SIMBAD:
Gumala: WDS 99456 = HIP 94645, from feat(catalogs): a Named Stars catalog of every IAU-named star, numbered by Hipparcos #695. The WDS position is 1.4″ from HD 179949. WDS's note K says that its magnitudes are K band, so its 4.94 is not a V.
fix(obslist): read observing-list designations with the catalog import's parser #693 changes no table.
Left, and follow-ups:
same_asto its Named Stars listing for HIP 9598.Testing
tests/test_catalog_corrections.py:nan,inf,-5,0and a negative axis in a size,was.size = "nan",guard = true, a non-booleanguard, andguardwithout asame_as) and five new tests: a farsame_asfails, an incompatible type fails,guard = falselets a far one through, a redundantguard = falsefails, and the guard sees the target as corrected;test_shipped_corrections_loadpasses with these files.🤖 Generated with Claude Code