Repository navigation
fix: read an error body by its code, not by a message - #29
Merged
Merged
Conversation
7dbede2 merged json()'s and send()'s error handling into `ServiceError.fromResponse`, keeping send()'s `"message" in body` test. json() had read any body with a `code`, as servers send them: `{ code, details }`, never the thrown message, which can leak internals. Since then such a body lost its code and details and read as UNKNOWN. `fromResponse` again reads a body with a status `code`, keeps its details, and takes its message from the first localised detail, or the status text. Co-Authored-By: LLM <noreply@block65.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 7dbede2 (v13.0.0),
ServiceError.fromResponsereads a body's code and details only when the body has amessage. That condition came from the oldsend()path, whilejson()had read any body with acode.A server using the standard error body sends
{ code, details }and never the thrown message, which can leak internals. So every such error reached clients as UNKNOWN, with anhttp-<status>detail.fromResponsenow:code;It never reads a top-level
message.The test server's JSON error fixture now sends the standard body. There are new tests for a body with a localised detail, a body without one, and a body that isn't an error body.