Repository navigation
fix: keep an error body's own message - #30
Closed
maxholman[bot] wants to merge 1 commit into
Closed
maxholman[bot] wants to merge 1 commit into
maxholman[bot] wants to merge 1 commit into
Conversation
6af2c9f read a body by its code but took the message only from a localised detail or the status text, so a body that sent its own `message` lost it: a 401 that said "Unauthenticated" read as "Unauthorized". A body's `message` is written to be sent, as `toJSONSummary` writes it, so it comes first again, as in 16.0.1. Co-Authored-By: LLM <noreply@block65.dev>
Contributor
Author
|
Not needed: the consumer's tests asserted an error message string; they now assert the code. 16.0.2's behaviour stands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed without merging: not needed.