Repository navigation
ci: add pull request validation - #155
Merged
Merged
Conversation
marcoallegretti
marked this pull request as ready for review
October 23, 2026 14:34
Owner
|
thanks! LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an initial CI baseline for pull requests and pushes to
main.The workflow provides separate results for:
The Rust job uses the development environment pinned by
flake.lock, prepares/tmp/.X11-unixwith the permissions expected by the socket tests, and caches Cargo downloads and build artifacts using the Rust and Nix dependency state.The development shell now also provides a fontconfig fallback. This was necessary because the text-rendering tests depend on a discoverable default font and otherwise fail on minimal environments. The fallback is supplied by nixpkgs and does not change the public API or packaged runtime.
Validation
The following checks pass:
cargo fmt --all -- --checkcargo test --workspace --all-targets --locked --no-runcargo test --workspace --all-targets --lockednpm run typechecknpm run test:overlaysnpm run test:output-powernix flake check --no-buildThe Rust workspace result is 404 passed and 4 ignored. The ignored tests remain explicitly marked as requiring surfaceless EGL or OpenGL ES.
The build still reports two existing
irrefutable_let_patternswarnings in thescene3dtests. This PR does not broaden its scope to address them.Scope
This intentionally does not add strict Clippy enforcement, hardware-dependent compositor tests, Nix package builds, or cross-architecture execution. Those can be evaluated separately once the baseline produces real CI timing and cache data.
API impact
No API break.
Part of #152.