Repository navigation
Conversation
Contributor
Author
|
This change is functionally independent from #155, but it should be considered after that PR is merged. #155 establishes the project’s CI baseline. Once it lands, this branch can be rebased onto the updated Until then, I will keep this PR in draft. |
bea4dev
marked this pull request as ready for review
October 24, 2026 11:18
Owner
|
thanks! LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 58 redundant borrows from the TTY and Winit rendering backends.
Clippy identified these expressions as references that Rust immediately dereferences again. The affected values were already references, so the additional borrow introduced unnecessary indirection without changing ownership or behavior.
Changes
clippy::needless_borrow.Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked -- -D clippy::needless-borrowNo new tests were added because this only simplifies call-site reference forwarding and introduces no new behavior.
API impact
No API break. No public types, signatures, or ownership contracts are changed.
Closes #157