Skip to content

chore: date the v1.0.1 changelog - #135

Merged
adriannoes merged 1 commit into
mainfrom
development
Oct 18, 2026
Merged

adriannoes merged 1 commit into
mainfrom
development

Conversation

@adriannoes

Copy link
Copy Markdown
Collaborator

Dates the [Unreleased] section as 1.0.1 for the release cut; no code changes.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary
Docs-only change (CHANGELOG.md, +4/-1): it moves the accumulated fixes from [Unreleased] into a dated [1.0.1] - 2026-10-18 section and updates the compare links. The structure follows Keep a Changelog and the link updates are correct. The release metadata in code is not bumped, so merging this to main and tagging v1.0.1 would ship a binary that still says 1.0.0.

Must Fix

  • None for the changelog itself. One item below is a blocker for the tag, not for this PR. Decide whether to fix it here or in the release commit.

Should Fix

  • src/core/version.h:9 still has #define SHELLCLAW_RELEASE_VERSION "1.0.0". That macro feeds the gateway /health version (src/gateway/http_lws.h:22), the signed ASAP manifest version (src/asap/manifest_build.c:429) and the ShellClaw <version> dispatch reply (tests/test_dispatch.c:243). CHANGELOG.md:75 states that gateway health matches this macro. After this PR the changelog and the binary disagree. Worse, publish-manifest.yml publishes the manifest to GitHub Pages on v* tags, so a v1.0.1 tag would publish a signed manifest that claims 1.0.0. Bump the macro to 1.0.1 in the same release flow. The tests use the macro rather than a literal, so they should keep passing.
  • The release date is set to 2026-10-18 and the [1.0.1] compare link (CHANGELOG.md:167) points at v1.0.0...v1.0.1. That tag does not exist yet (only v1.0.0 is on the remote), so the link returns 404 until you tag. If the tag is not cut right after merging, keep the date and link in sync with the real tag day. Also confirm that merging to main is when you want to cut the release, since the date commits you to it.

Nice to Have

  • CHANGELOG.md:5-7: [Unreleased] is now empty. That is fine, but the repo has no check that stops later PRs from adding entries under a released heading by mistake. Past PRs here had to fix this by hand (the "changelog sync" merge commits). A small CI grep could help. This is optional.
  • The 1.0.1 section lists only fixes. AGENTS.md (Known debt) and docs/ASAP.md (Deferred v1.0.1+) still describe the tool_X_set_config refactor, the config.c split and the live ASAP endpoint/compliance work as "scheduled for v1.0.1". Those items are not in this release. Retarget them to v1.0.2 or v1.1.0 so the docs do not contradict the release notes.
  • Several bullets are very long (the compaction and cron ones in particular). Consider shortening them for readers who only skim a release.

Positive Highlights

  • The scope is minimal: one file, one logical change, and the link block at the bottom was updated together with the heading, which is the part that is often forgotten.
  • The release notes are user-facing. They name the observable behavior and, where it matters (sandbox env scrub, interval: validation, the 365d snooze), point to the detail docs and the issue number.
Open in Web聽View Automation聽

Sent by Cursor Automation: Code review

@adriannoes
adriannoes merged commit 5d1bfad into main Oct 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant