Repository navigation
chore: date the v1.0.1 changelog - #135
Merged
Merged
Conversation
There was a problem hiding this comment.
Summary
Docs-only change (CHANGELOG.md, +4/-1): it moves the accumulated fixes from [Unreleased] into a dated [1.0.1] - 2026-10-18 section and updates the compare links. The structure follows Keep a Changelog and the link updates are correct. The release metadata in code is not bumped, so merging this to main and tagging v1.0.1 would ship a binary that still says 1.0.0.
Must Fix
- None for the changelog itself. One item below is a blocker for the tag, not for this PR. Decide whether to fix it here or in the release commit.
Should Fix
src/core/version.h:9still has#define SHELLCLAW_RELEASE_VERSION "1.0.0". That macro feeds the gateway/healthversion (src/gateway/http_lws.h:22), the signed ASAP manifest version (src/asap/manifest_build.c:429) and theShellClaw <version>dispatch reply (tests/test_dispatch.c:243).CHANGELOG.md:75states that gateway health matches this macro. After this PR the changelog and the binary disagree. Worse,publish-manifest.ymlpublishes the manifest to GitHub Pages onv*tags, so av1.0.1tag would publish a signed manifest that claims 1.0.0. Bump the macro to1.0.1in the same release flow. The tests use the macro rather than a literal, so they should keep passing.- The release date is set to 2026-10-18 and the
[1.0.1]compare link (CHANGELOG.md:167) points atv1.0.0...v1.0.1. That tag does not exist yet (onlyv1.0.0is on the remote), so the link returns 404 until you tag. If the tag is not cut right after merging, keep the date and link in sync with the real tag day. Also confirm that merging tomainis when you want to cut the release, since the date commits you to it.
Nice to Have
CHANGELOG.md:5-7:[Unreleased]is now empty. That is fine, but the repo has no check that stops later PRs from adding entries under a released heading by mistake. Past PRs here had to fix this by hand (the "changelog sync" merge commits). A small CI grep could help. This is optional.- The 1.0.1 section lists only fixes.
AGENTS.md(Known debt) anddocs/ASAP.md(Deferred v1.0.1+) still describe thetool_X_set_configrefactor, theconfig.csplit and the live ASAP endpoint/compliance work as "scheduled for v1.0.1". Those items are not in this release. Retarget them to v1.0.2 or v1.1.0 so the docs do not contradict the release notes. - Several bullets are very long (the compaction and cron ones in particular). Consider shortening them for readers who only skim a release.
Positive Highlights
- The scope is minimal: one file, one logical change, and the link block at the bottom was updated together with the heading, which is the part that is often forgotten.
- The release notes are user-facing. They name the observable behavior and, where it matters (sandbox env scrub,
interval:validation, the 365d snooze), point to the detail docs and the issue number.
Sent by Cursor Automation: Code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Dates the [Unreleased] section as 1.0.1 for the release cut; no code changes.