Repository navigation
fix(fullscreen): support Safari and improve mobile fallback - #272
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying markdownviewer with
|
| Latest commit: |
14decce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dee777c2.markdownviewer.pages.dev |
| Branch Preview URL: | https://fix-264-mobile-safari-fullsc.markdownviewer.pages.dev |
Owner
Author
|
@wwdd48s8km-bit Please try it and check if it is working correctly now. Do let me know if you notice any issues. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fullscreen button silently does nothing when the browser has no standard element Fullscreen API. Older iPad Safari requires the prefixed API, and iPhone Safari has a browser limitation for page fullscreen (WebKit tracking issue, Safari 16.4 support announcement).
Use the supported native API and wait for its completion/error events, including older Safari's event-only methods. When native fullscreen is unavailable or denied, offer an explicitly named Expanded view and explain that browser controls remain visible.
Validation:
npm run build: passed.npm run test:unit: 22 passed.trash.spec.js:240at the Restore button disabled-state assertion after cancelling deletion and selecting an incomplete recovery record; an isolated rerun passed (1/1). The full run is not reported as fully green.14decce: Vercel, Cloudflare Pages, Docker build, and GitGuardian all passed.Before the update, regression cases reproduced the disabled exit control and missing legacy Safari API support on the previous PR revision. Those cases now pass in Chromium, Firefox, and WebKit.
The Safari compatibility cases use controlled API simulations and the local WebKit browser. A physical iPhone/iPad was not available; this change cannot enable Safari's missing native iPhone capability.
Closes #264