Skip to content

Fix staged validation and isolate bridge project failures - #16

Merged
TheLinuxGuy merged 1 commit into
mainfrom
codex/quality-boundaries
Oct 26, 2026
Merged

TheLinuxGuy merged 1 commit into
mainfrom
codex/quality-boundaries

Conversation

@TheLinuxGuy

Copy link
Copy Markdown
Owner

What changed and why

A bad project configuration could stop every bridge export without updating diagnostics, and staged lint could accept links to files that would not be committed. Markdown tools also disagreed about nested fences, while setup enrollment duplicated the task-import Git transaction.

  • Validate each project's configuration once per sync and reuse that snapshot for inventory, rename permissions and imports. Project failures preserve the previous export and pause only that project; healthy projects continue and diagnostics update. Setup and invalid plan inventories remain strict.
  • Add a shared document source for disk or Git-index contents, exact-case target lookup and listings. The pre-commit hook checks the complete staged document graph, configuration, CSV tables and README index, including incoming links to deleted documents and changed headings. Working-copy-only fixes cannot hide staged errors.
  • Share one disposable-clone transaction between enrollment and imports, including hooks, Git identity, concurrent-edit checks, fast-forward publication and cleanup.
  • Share one offset-preserving Markdown fence scanner and heading inventory across TOCs, anchors, heading/file rewrites, table lint and bridge task discovery. Shorter, mismatched and unclosed fences are handled consistently; CRLF task imports preserve their source lines.

Public documentation describes the corrected behavior. Review focus: _tools/selftest.py adds real CLI/hook regressions for index-versus-disk differences, config isolation, nested fences and concurrent live edits.

Validation

  • uv run _tools/selftest.py baseline: 492/492; final complete suite under coverage: 523/523.
  • uv run .github/scripts/test_public_docs.py: 241/241.
  • uv run .github/scripts/ci_coverage.py: 93.25% production line coverage; local diff calculation: 213/221 changed executable lines covered (96.38%).
  • uvx ruff@0.17.2 check --no-cache --config ruff.toml ..
  • python3 _tools/framework_guard.py passes after staging; git diff --cached --check passes.
  • Changed behavior has self-tests and public documentation; examples are fictional.

Needs careful review (check if touched)

  • Workflows, .github/scripts/, .coveragerc, codecov.yml, ruff.toml
  • .gitignore allowlist or _tools/framework_guard.py
  • Coverage thresholds or exclusions

Copilot AI balanced review requested due to automatic review settings October 26, 2026 06:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.38009% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (3dcfb3d) to head (79e1666).

Files with missing lines Patch % Lines
_tools/icloud_bridge.py 95.23% 4 Missing ⚠️
_tools/docslib.py 94.91% 3 Missing ⚠️
_tools/docsource.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   91.87%   92.20%   +0.32%     
==========================================
  Files          16       17       +1     
  Lines        3128     3143      +15     
==========================================
+ Hits         2874     2898      +24     
+ Misses        254      245       -9     
Files with missing lines Coverage Δ
_tools/docs_lint.py 92.40% <100.00%> (+0.54%) ⬆️
_tools/docs_mv.py 90.72% <100.00%> (+1.21%) ⬆️
_tools/docsextra.py 84.04% <100.00%> (+0.81%) ⬆️
_tools/docsource.py 97.56% <97.56%> (ø)
_tools/docslib.py 90.54% <94.91%> (+0.39%) ⬆️
_tools/icloud_bridge.py 93.33% <95.23%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheLinuxGuy
TheLinuxGuy merged commit e5e4ef8 into main Oct 26, 2026
13 checks passed
@TheLinuxGuy
TheLinuxGuy deleted the codex/quality-boundaries branch October 26, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants