Repository navigation
Wire filter presets, the directions picker and report-a-problem into the map - #331
Merged
yakew7 merged 1 commit intoNov 2, 2026
Conversation
Contributor
|
@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Part of #313: three more items from its checklist, wired in one PR. The other items stay open, so this does not use "Fixes".
FilterPresetsgoes intoMapPanelright under the category chips. One tap applies Libraries, SAT centres, Exam centres (both exam types), Govt offices or Airports by replacing the active type filter, through the existingonFiltersChange, so?types=and the results update as before.DirectionsModalis what the pin popup's directions button now opens. It was a plain Google link; the modal offers Google Maps, Apple Maps and an Androidgeo:link. The popup's main "Google Maps" button still links straight to the place.ReportIssueDialogis opened by a new "Report a problem" link in the popup footer. It builds a pre-filled GitHub issue for that place, as the component was written to do.Tests
filter-presets.test.tsx(new, 3 tests): the group and its five buttons, a single-type preset, and the two-type Exam centres preset.pin-popup.test.tsx(new, 4 tests): the directions button opens the picker with Apple Maps andgeo:links, the direct Google Maps link is still there, and "Report a problem" opens the report dialog for that place.places-map.test.tsx: one new case: clicking the Airports preset narrows the list and setstypes=airportin the URL.Proof
npm run devat/map: the five preset buttons render under the chips, and clicking Airports changes the URL to?types=airport&...and the panel to "117 places shown" (the number of records inairport.jsonis 117 in the checked-out data).npm run lint,npm run typecheck,npm run format:checkare clean;npm run test:unit: 654 passed.Not verified
I did not open a pin popup in the browser (I could not get one to open from a link in the automated run), so the two dialogs inside the Leaflet popup are covered by unit tests only. One thing to look at: the dialogs render in a portal while the popup is a Leaflet popup, and I have not checked what happens if the popup is closed while a dialog is open.
Type of change