Repository navigation
Fix two copy-pasted SAT centre coordinates and remove the Shawnigan Lake duplicate - #330
Merged
yakew7 merged 1 commit intoNov 2, 2026
Conversation
Contributor
|
@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two data clean-ups in one PR. Part of #247 and a follow-up to the same-name check added in #319, which now warns about two pairs this PR clears.
1. Near-duplicate coordinates (part of #247). The issue lists three pairs: Benin City, Malatya and Ankara. The Malatya pair is already fixed on
main(the two schools are now about 12 km apart). The Ankara pair is fixed here, along with a Nagoya pair that the validator now reports and the issue does not list. The Benin City pair is left (see below).67236) had exactly the same coordinates as Enishi International School (67369), a copy-paste. Enishi's point matches OpenStreetMap (35.1802637, 136.8836358, Nishi Ward), so the other record was the wrong one. Wikipedia gives the school's location as35.24306, 137.03278for its listed address (2686 Minamihara Nakashidami, Moriyama-ku), and OpenStreetMap roads named for that district sit at about35.24 to 35.25, 137.02 to 137.03. The record now uses35.24306, 137.03278, and itsgmaps_linkis updated to match.59293, address Meksika Cad, Ümit Mah) sat 38 m from TED University because its point was in Çankaya's Fidanlık area, nowhere near Meksika Caddesi. OpenStreetMap has "Jale Tezer Okulları Ümitköy Kampüsü" at39.9021252, 32.6987588, on Ümit Mah. That is now the record's point and link. TED University's own point is about 400 m from OpenStreetMap's TED campus, which I left alone.2. Duplicate place.
shl-other_places-01and sat_centre94465are the same school (Shawnigan Lake School, 1975 Renfrew Road). OpenStreetMap's point for the school equals thesat_centrerecord's coordinates exactly, so theother_placescopy is removed, as #285 did for the other doubled schools. Nothing in the repo refers to the removed id.Not fixed (needs someone with the exact addresses)
66357) and Nathan American Academy (43290), the last pair in data: resolve 3 remaining near-duplicate-coordinate warnings in sat_centre.json #247: about 16 m apart on different streets. I could not find either school on OpenStreetMap or on the schools' own sites, so I did not guess. The warning remains.other_placesrecord (Rugaylat Road,25.0991, 56.3581) and thesat_centrerecord (Sheikh Hamad Bin Saeed Alqassimi,25.0513, 56.3542) are about 5 km apart with different addresses, and OpenStreetMap's "American School" on Sheikh Hamad Bin Saeed Al Qassimi street is at25.0734, 56.3552, between them. That could be a move or a wrong point, so I left both records and the warning.Proof
npm run validate: passes with 3 warnings (down from 6): the two I fixed are gone, the three above remain.npm run format:checkandnpm run test:unit(647 passed) are clean.Type of change