Skip to content

Fix two copy-pasted SAT centre coordinates and remove the Shawnigan Lake duplicate - #330

Merged
yakew7 merged 1 commit into
StudentSuite:mainfrom
propcgamer20-png:fix/sat-near-duplicate-coordinates
Nov 2, 2026
Merged

yakew7 merged 1 commit into
StudentSuite:mainfrom
propcgamer20-png:fix/sat-near-duplicate-coordinates

Conversation

@propcgamer20-png

@propcgamer20-png propcgamer20-png commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

What this changes

Two data clean-ups in one PR. Part of #247 and a follow-up to the same-name check added in #319, which now warns about two pairs this PR clears.

1. Near-duplicate coordinates (part of #247). The issue lists three pairs: Benin City, Malatya and Ankara. The Malatya pair is already fixed on main (the two schools are now about 12 km apart). The Ankara pair is fixed here, along with a Nagoya pair that the validator now reports and the issue does not list. The Benin City pair is left (see below).

  • Nagoya International School (67236) had exactly the same coordinates as Enishi International School (67369), a copy-paste. Enishi's point matches OpenStreetMap (35.1802637, 136.8836358, Nishi Ward), so the other record was the wrong one. Wikipedia gives the school's location as 35.24306, 137.03278 for its listed address (2686 Minamihara Nakashidami, Moriyama-ku), and OpenStreetMap roads named for that district sit at about 35.24 to 35.25, 137.02 to 137.03. The record now uses 35.24306, 137.03278, and its gmaps_link is updated to match.
  • Jale Tezer Education Institutions (59293, address Meksika Cad, Ümit Mah) sat 38 m from TED University because its point was in Çankaya's Fidanlık area, nowhere near Meksika Caddesi. OpenStreetMap has "Jale Tezer Okulları Ümitköy Kampüsü" at 39.9021252, 32.6987588, on Ümit Mah. That is now the record's point and link. TED University's own point is about 400 m from OpenStreetMap's TED campus, which I left alone.

2. Duplicate place. shl-other_places-01 and sat_centre 94465 are the same school (Shawnigan Lake School, 1975 Renfrew Road). OpenStreetMap's point for the school equals the sat_centre record's coordinates exactly, so the other_places copy is removed, as #285 did for the other doubled schools. Nothing in the repo refers to the removed id.

Not fixed (needs someone with the exact addresses)

  • Cradle High School - Benin (66357) and Nathan American Academy (43290), the last pair in data: resolve 3 remaining near-duplicate-coordinate warnings in sat_centre.json #247: about 16 m apart on different streets. I could not find either school on OpenStreetMap or on the schools' own sites, so I did not guess. The warning remains.
  • American School of Kalba: the other_places record (Rugaylat Road, 25.0991, 56.3581) and the sat_centre record (Sheikh Hamad Bin Saeed Alqassimi, 25.0513, 56.3542) are about 5 km apart with different addresses, and OpenStreetMap's "American School" on Sheikh Hamad Bin Saeed Al Qassimi street is at 25.0734, 56.3552, between them. That could be a move or a wrong point, so I left both records and the warning.
  • The Nairobi pair (Goethe-Institut and Alliance Française, about 30 m apart) is an existing warning I did not look at.

Proof

npm run validate: passes with 3 warnings (down from 6): the two I fixed are gone, the three above remain. npm run format:check and npm run test:unit (647 passed) are clean.

Type of change

  • Code or fix
  • New public place(s)
  • New or updated benefit guide
  • New or updated resource link
  • Docs

@vercel

vercel Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@propcgamer20-png is attempting to deploy a commit to the studentsuite Team on Vercel.

A member of the Team first needs to authorize it.

@yakew7
yakew7 merged commit 750f16a into StudentSuite:main Nov 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants