Skip to content

Prepare for Dart Sass - #95

Merged
alexander-yevsyukov merged 2 commits into
masterfrom
claude/dart-sass-prerequisites-087af0
Oct 30, 2026
Merged

alexander-yevsyukov merged 2 commits into
masterfrom
claude/dart-sass-prerequisites-087af0

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

Part of SpineEventEngine/site-commons#38.

Hugo deprecated LibSass in v0.153.0 and will remove it. The site-commons theme is moving its stylesheet to the dartsass transpiler. Once this repo updates to that theme version, Hugo needs the Dart Sass sass executable on PATH, both locally and in CI. Without it, the build fails. This PR gets CI and contributors ready first. Installing Dart Sass does no harm while the site still uses LibSass.

Changes

  • .github/workflows/check-links.yml:
    • Pin Dart Sass 1.99.0 and the SHA-256 of its linux-x64 release tarball in env:, next to the Lychee pins.
    • The new Install Dart Sass step downloads the tarball from the GitHub release, verifies its checksum, and adds dart-sass/ to PATH.
    • The new Check Dart Sass step runs hugo env | grep 'github.com/sass/dart-sass', so the log shows that Hugo finds Dart Sass.
  • README.md: add Dart Sass to the prerequisites, with the Homebrew command and the hugo env check.

The theme version in docs/_preview/go.mod stays the same. It changes in the usual theme-update PR, after the site-commons Dart Sass PR merges.

check-links.yml must match config

SpineEventEngine/config distributes this workflow. The same change is being made there. Once that PR lands, this file must match config's copy byte for byte.

Testing

  • The pinned checksum matches the release tarball (shasum -a 256).
  • Locally, hugo env lists github.com/sass/dart-sass/... when sass is on PATH. Without it, the grep fails.
  • This PR's Check Links run is the first CI run of the new steps.

🤖 Generated with Claude Code

alexander-yevsyukov and others added 2 commits October 30, 2026 16:40
Hugo deprecated LibSass in v0.153.0. Once the `site-commons` theme
switches its stylesheet to the `dartsass` transpiler, Hugo needs the
Dart Sass `sass` executable on `PATH`, or the build fails.

Install Dart Sass 1.99.0 from the GitHub release, verify its SHA-256,
and check that `hugo env` lists it. Installing it is harmless while the
theme still uses LibSass.

The change mirrors the same edit in `SpineEventEngine/config`, which
distributes this workflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 30, 2026 16:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T16:42:47.466889Z 7449fe2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are recorded for the CI and documentation changes preparing for the Dart Sass migration.

No open issues 🎉

What changed in this PR

Prepares CI and contributors for the upcoming site-commons migration to Dart Sass without changing the theme version.

Changes:

  • Adds pinned, checksum-verified Dart Sass installation and a Hugo detection check to CI.
  • Documents the local Dart Sass prerequisite, Homebrew installation, and verification command.
File Description
README.md Adds Dart Sass setup and verification instructions.
.github/​workflows/​check-links.yml Installs Dart Sass and checks that Hugo detects it.

Review effort: Balanced

@alexander-yevsyukov
alexander-yevsyukov merged commit 3045fa4 into master Oct 30, 2026
6 checks passed
@alexander-yevsyukov
alexander-yevsyukov deleted the claude/dart-sass-prerequisites-087af0 branch October 30, 2026 16:43
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in v2.0 Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants