Repository navigation
Read GPP consent from the IAB's SharedPreferences keys - #49
Open
jrosendahl-opt wants to merge 1 commit into
Open
jrosendahl-opt wants to merge 1 commit into
jrosendahl-opt wants to merge 1 commit into
Conversation
The IAB GPP CMP API spec has in-app CMPs store the GPP string under IABGPP_HDR_GppString and the section IDs under IABGPP_GppSID (underscore-separated). The SDK read IABGPP_2_TCString, which isn't an IAB key, and never read the section IDs. - Read IABGPP_HDR_GppString first, keep IABGPP_2_TCString as a fallback. - Read IABGPP_GppSID and convert "2_7" to "2,7" for the Edge API. - Use the CMP's section IDs only when the GPP string also came from the CMP. - An explicit gppSid always wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
Merged
mosherBT
approved these changes
Nov 9, 2026
| */ | ||
| fun getGppSid(): String? { | ||
| try { | ||
| return prefs.getString(KEY_GPP_SID, null)?.replace("_", ",") |
Contributor
There was a problem hiding this comment.
If the stored value is empty, this sends gpp_sid=. Should it return null when blank?
| return customConsents.gppSid | ||
| } | ||
| // The CMP's section IDs are only used with the CMP's GPP string, never with a custom one. | ||
| if (customConsents.gpp == null && localStorage.getGppConsent() != null) { |
Contributor
There was a problem hiding this comment.
This also passes when the GPP string comes from the legacy key, so the CMP's section IDs get sent with a string the CMP didn't write. Should it only use them when IABGPP_HDR_GppString is set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The IAB GPP CMP API spec has in-app CMPs store the GPP string under
IABGPP_HDR_GppStringand the applicable section IDs underIABGPP_GppSID(underscore-separated, e.g.2_7). The SDK readIABGPP_2_TCString, which isn't an IAB key, and never read the section IDs. With a spec-compliant CMP, nogppwas sent, andgpp_sidwas never sent unless the app setOptableConsents.gppSid.Same fix as the iOS SDK (Optable/optable-ios-sdk#86).