Repository navigation
Use the consents passed in OptableConfig - #50
Open
jrosendahl-opt wants to merge 1 commit into
Open
jrosendahl-opt wants to merge 1 commit into
jrosendahl-opt wants to merge 1 commit into
Conversation
OptableConfig.consents was never read: OptableSDK created its ConsentsManager with empty consents, so consents passed in the config were silently dropped and only setConsents() had an effect. Start the ConsentsManager with config.consents; setConsents() still replaces them. The README note now says what the code does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
Merged
mosherBT
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OptableConfighas a publicconsentsparameter, documented as "custom consent information", but nothing read it:OptableSDKcreated itsConsentsManagerwith empty consents. Consents passed in the config were silently dropped, and onlysetConsents()had an effect. The README note said the opposite ("The custom values provided to theOptableConfigwill override…").consentsinOptableConfigwill now send them (gdpr,gdpr_consent,gpp,gpp_sid,reg), and they take precedence over SharedPreferences values. As they expected to happen.