Repository navigation
Conversation
MattiSG
left a comment
MattiSG
left a comment
There was a problem hiding this comment.
Hey LLM contributor @natesute, this is not a relevant implementation. Also, no one asked you for anything and you're taking up maintainer time for stuff you don't use or care about and for which you're lacking context. Please stop opening PRs here without context. Next time your account will be banned.
| it('does not declare the same source document more than once', () => { | ||
| const duplicateLocations = [...new Set(terms.duplicateSourceDocuments.map(sourceDocument => sourceDocument.location))]; | ||
| it('does not declare source documents with colliding IDs', () => { | ||
| const duplicateDocuments = terms.duplicateSourceDocuments.map(({ id, location }) => `${location} (ID: "${id}")`); |
There was a problem hiding this comment.
How can you .map({ id, location }) when you only.add(id) in the duplicateSourceDocuments getter? The set returned by duplicateSourceDocuments does not contain location anymore.
| const secondDocument = new SourceDocument({ location: secondLocation }); | ||
| const terms = new Terms({ service, type: termsType, sourceDocuments: [ firstDocument, secondDocument ] }); | ||
|
|
||
| expect(terms.duplicateSourceDocuments).to.deep.equal([secondDocument]); |
There was a problem hiding this comment.
We really don't want to rigidify that behaviour. Detecting those as duplicates is a side-effect of the current insufficient ID derivation function, but they should not be.
2 participants
Combined source URLs can map to the same snapshot ID even when their URLs differ. Declaration validation now compares those IDs and reports the conflicting URL and ID, following the approach suggested in #1278. ID generation and existing snapshot paths are unchanged.
Adds regression cases for collisions across hosts, query strings, file extensions and flattened paths, plus a distinct-ID control. The four collision cases fail before the fix.
Validation: 56 targeted Terms, SourceDocument and declaration-schema tests pass. Repository ESLint passes with an explicit config to avoid inheriting the enclosing worktree checkout's config.
Fixes #1278