Skip to content

Detect duplicate snapshot IDs in combines - #1289

Closed
dannyward630 wants to merge 1 commit into
OpenTermsArchive:mainfrom
dannyward630:1278-validate-source-document-id-collisions
Closed

dannyward630 wants to merge 1 commit into
OpenTermsArchive:mainfrom
dannyward630:1278-validate-source-document-id-collisions

Conversation

@dannyward630

Copy link
Copy Markdown

Summary

  • Compare combined source documents by the snapshot ID the recorder writes.
  • Report every URL that shares a snapshot ID.
  • Cover host and query string collisions with regression tests.

Fixes #1278

Validation

  • npm run test:only src/archivist/services/terms.test.js — 4 passing
  • npx eslint src/archivist/services/terms.js src/archivist/services/terms.test.js scripts/declarations/validate/index.mocha.js — passed
  • npm test --ignore-scripts — 1,652 passing, 174 pending, 38 failing in this Windows run. Failures appeared in PDF newline comparisons, fixture locks/timeouts, and export fixtures; the changed Terms tests passed.

Assisted by Codex (GPT-6).

@MattiSG

MattiSG commented Oct 19, 2026

Copy link
Copy Markdown
Member

Duplicate of #1280.

LLM contributor @dannyward630, this is not a relevant implementation. Also, no one asked you for anything and you're taking up maintainer time for stuff you don't use or care about and for which you're lacking context. Please stop opening PRs here without context. Next time your account will be banned.

@MattiSG MattiSG closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source documents sharing a URL path in a combine overwrite each other's snapshots

2 participants