Repository navigation
Correct failure alert and digest details - #926
Merged
Merged
Conversation
1 of 3 tasks
taylordowns2000
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Corrects the failure alert and digest page against current Lightning: alert emails link to the logs rather than including them, and digests count work orders.
Details
Checked against
OpenFn/lightningmainat3b9f4a2f9b.Changed in
docs/manage-projects/notifications.md:lib/lightning/pipeline/failure_alerter.ex).failure_alert.html.heex).config/config.exs).project_user.ex), and you can only change your own settings (policies/project_users.ex).config/bootstrap.ex). They link to History and, if there were failures, to workflow health.Left for later:
Screenshots need retaking.lightning_failure_email.webpshows logs inside the email and old wording, so it now contradicts the text.lightning_weekly_digest.webpshows old digest wording. We don't retake screenshots with AI.docs/covers it. It needs its own page under Monitor & History.###, the intro is two paragraphs that say the same thing, and the alt text doesn't describe the images. These were Could changes in the report.machinestatus) needs retranslating after this merges.identify-gaps report
Covered
docs/manage-projects/notifications.mdagainstOpenFn/lightningorigin/main3b9f4a2f9b. 1 Must, 4 Should, 4 Could, 1 Question.Must
failure_alert.html.heexonly links to the run and its logs — say it links to the work order, run and logs, and workflow health.Should
failure_alerter.ex:17) — change to run.config/config.exs:193), defaults (off / Never,project_user.ex:37-39), and that you can only change your own settings (policies/project_users.ex:51).digest_email_worker.ex:159); add send times (10:00 UTC daily / Monday / 1st,bootstrap.ex:294-299) and the History and health links.lightning_failure_email.webpandlightning_weekly_digest.webpare out of date — a human needs to retake them.Could
###; STYLE.md says##.NotificationsandDigestsin code formatting.lightning_failed_run.webpadds little.Questions
project_limiter.ex:11)? Is it plan-dependent on app.openfn.org?AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy