Repository navigation
fix(flow): skill hints through command(); guard tests back on the PR lane - #1632
Merged
Merged
Conversation
…guards back on the PR lane Main's Packages run fails tests/test_cli_hints.py::test_printed_hints_never_hard_code_the_engine_spelling on registry.py's pull hint (#1623), which printed a literal "openadapt-flow skill ...". Under the launcher that names a program the person never typed; it now goes through cli_hints.command() like every other hint. #1623's own CI never ran the test: #1608 moved it to nightly as a 6 s test, though it is a source scan that guards every printed hint. It returns to the pull-request lane, with five safety guards the same rule moved by mistake: identity (a numeric MRN homonym never verifies), durable resume (never resends), the safety gallery (every dangerous case is safe), halt detail (a typed value never appears) and self-repair (a healthy run never calls the agent). Together they add about 90 test-seconds across the four shards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's Packages push run (40809648930) fails one test:
tests/test_cli_hints.py::test_printed_hints_never_hard_code_the_engine_spelling. It flagsregistry.py:795-796, where #1623's pull command printed a literalopenadapt-flow skill bind/qualify .... Under the launcher that names a program the person never typed. The hint now goes throughcli_hints.command(), like every other hint.Why #1623's CI passed: #1608 moved this test to nightly because it takes 6 s. That was my mistake: it's a source scan that guards every printed hint, so it belongs on the PR lane. It's back, with five safety guards the same >5 s rule moved:
Together they add about 90 test-seconds across the four PR shards.
Checked locally:
test_cli_hints, the three registry test files andtest_lanespass (110 passed, 4 skipped), and ruff is clean.