Repository navigation
Conversation
skill pull printed 'openadapt-flow skill bind' and 'openadapt-flow skill qualify' as literals. Under the launcher that names a program the person never typed, and test_cli_hints.py's test_printed_hints_never_hard_code_the_engine_spelling fails on it, which turned main's flow core unit shard red after #1623 (run 40809648930). The hint now goes through cli_hints.command(), like every other next step.
abrichr
enabled auto-merge (squash)
October 29, 2026 03:29
Member
Author
|
Superseded by #1632, which made the same fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's post-merge Packages run fails
flow core unit (shard 2/2)(run 40809648930):skill pull(#1623) printsopenadapt-flow skill bind ...andopenadapt-flow skill qualify ...as literals. Under the launcher that names a program the person never typed. The PR lane leaves this test out of its fast shard, so it showed up only on main. It's deterministic, so it also blocks openadapt-flow 2.4.1 from publishing:release-package.ymlwaits for a green Packages run on the newest Flow commit.Change
The hint goes through
cli_hints.command(), like every other printed next step.Checks
tests/test_cli_hints.pyand the registry tests pass locally (112 tests). ruff is clean.