fix(migrate): pass the uniqueness argument the read result pin's shaped multiplicity takes - #800
Merged
Merged
Conversation
…ed multiplicity takes Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
developdoes not build since #791 and #795 landed independently of each other: #795 gaveshapeda fourth argument (unique, whether the usage must be written withoutnonunique), and #791's new read of aReadStructuralFeatureActionresult pin inactivity.readFeaturestill calls it with three:The result pin is written as an
outparameter of the read action. A parameter implicitly subsets nothing (implicitlyUniquereturns "" for a directed usage), so, as at the other two pin sites (activity.gopinDecl,behavior.go), it keeps whateverisUniquethe pin declares:shaped(mult, r, true, false).How it was verified
On this branch:
go build ./...,go vet ./internal/translate/migrate,gofmt -lclean;go test -count=1 ./internal/translate/migrate ./tests/migratepass. The full suite runs in CI.Checklist
make testandmake lintpass locally (the affected packages; the rest is CI's)tests/migratefrom fix(migrate): declare script locals, keep read-pin multiplicity, ledger instant waits, UI stimuli and absent arguments #791make docs-countsrun if a gate count moved — none movedF4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/d4b4403c1dd54e0390049c64e3535b0f
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/d4b4403c1dd54e0390049c64e3535b0f?variant=devin
Requested by: @HuiJun