Repository navigation
fix(migrate): pass shaped its unique flag for a script's out parameter - #801
Closed
devin-ai-integration[bot] wants to merge 2 commits into
Closed
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
develop stopped building once #791 merged: the out-parameter line in activity.go still called shaped with three arguments after 7a60fd2 gave it a fourth, unique, so cmd/sysml and everything importing internal/translate/migrate failed to compile. Pass false, as the other pin and parameter call sites do. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
5 of 6 tasks
Co-Authored-By: jason.han <hanhuijun@gmail.com>
HuiJun
marked this pull request as ready for review
October 1, 2026 23:20
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
developdoes not build since #791 merged (76599c2):internal/translate/migrate/activity.go:2341still callsshaped(mult, r, true)while 7a60fd2 in the same PR gaveshapeda fourth parameter,unique.go build ./...fails ininternal/translate/migrate, which takescmd/sysml,cmd/sysml-grpcand every PR's "Build binaries", conformance and WebAssembly jobs with it (seen on #757 after mergingdevelopin).developruns no CI on push, so nothing flagged it.falseis what the other pin and parameter call sites pass (activity.go:1558,behavior.go:296,parameterShape): a script'soutparameter is not a usage that must be written unique, so the rendered text is what it was before 7a60fd2.How it was verified
go build ./...,go vet ./internal/translate/migrate,go test ./internal/translate/migratepass on this branch; onorigin/developthe build fails withnot enough arguments in call to shaped.gofmt -l .prints nothing;python3 scripts/changelog.py checkpasses. No changelog fragment: this restores a change that is itself still unreleased (fix(migrate): declare script locals, keep read-pin multiplicity, ledger instant waits, UI stimuli and absent arguments #791).Checklist
make testandmake lintpass locally (build gate; the package's tests pass)changes/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.md(not needed, see above)make docs-countsrun if a gate count moved (no count moved)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/6133aceea157486ca9ebddf387b4959d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/6133aceea157486ca9ebddf387b4959d?variant=devin
Requested by: @HuiJun