Skip to content

fix(migrate): pass shaped its unique flag for a script's out parameter - #801

Closed
devin-ai-integration[bot] wants to merge 2 commits into
developfrom
fix/migrate-shaped-arity
Closed

devin-ai-integration[bot] wants to merge 2 commits into
developfrom
fix/migrate-shaped-arity

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

develop does not build since #791 merged (76599c2): internal/translate/migrate/activity.go:2341 still calls shaped(mult, r, true) while 7a60fd2 in the same PR gave shaped a fourth parameter, unique. go build ./... fails in internal/translate/migrate, which takes cmd/sysml, cmd/sysml-grpc and every PR's "Build binaries", conformance and WebAssembly jobs with it (seen on #757 after merging develop in). develop runs no CI on push, so nothing flagged it.

-a.m.w.line("out " + writeName(pname) + shaped(mult, r, true) + " = " + expr + ";")
+a.m.w.line("out " + writeName(pname) + shaped(mult, r, true, false) + " = " + expr + ";")

false is what the other pin and parameter call sites pass (activity.go:1558, behavior.go:296, parameterShape): a script's out parameter is not a usage that must be written unique, so the rendered text is what it was before 7a60fd2.

How it was verified

Checklist

  • make test and make lint pass locally (build gate; the package's tests pass)
  • Tests added or updated for the change — compile-time break, covered by the build
  • Documentation extended where it already covers the surface (none covers this)
  • Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md (not needed, see above)
  • baselines regenerated and make docs-counts run if a gate count moved (no count moved)
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/6133aceea157486ca9ebddf387b4959d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/6133aceea157486ca9ebddf387b4959d?variant=devin
Requested by: @HuiJun

develop stopped building once #791 merged: the out-parameter line in activity.go still called shaped with three arguments after 7a60fd2 gave it a fourth, unique, so cmd/sysml and everything importing internal/translate/migrate failed to compile. Pass false, as the other pin and parameter call sites do.

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@HuiJun
HuiJun marked this pull request as ready for review October 1, 2026 23:20

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Superseded: develop already carries the identical one-line fix via #800 (d178d2b), so this is no longer needed.

@devin-ai-integration
devin-ai-integration Bot deleted the fix/migrate-shaped-arity branch October 1, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant