Skip to content

[IMP] help_popup module - #417

Closed
bealdav wants to merge 5 commits into
OCA:8.0from
akretion:8-help-popup-improvment
Closed

bealdav wants to merge 5 commits into
OCA:8.0from
akretion:8-help-popup-improvment

Conversation

@bealdav

@bealdav bealdav commented Sep 8, 2016 •

Copy link
Copy Markdown
Member
  • Improve report esthetic
  • Better way to complete doc: dedicate view on action window
  • Allow to display / print the doc for a complete base menu (Sales, Purchase, etc)
  • Provide a mechanism to update partially advanced_help and advanced_help_model fields: any other modules should can add or update some parts of these fields (data of several module in one fields)
  • Provide a mechanism to delete properly help data at uninstall of the module (several modules have modified help fields)
  • add test unit

popup


When you click on 'Sales help' above, you open the report below (all documentation of the menu sales).
sales_doc


Here is a dedicate view on action window to modify end users help fields

img3

Comment thread help_popup/model.py Outdated
# © 2015 David BEAL @ Akretion <david.beal@akretion.com>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from BeautifulSoup import BeautifulSoup as BSHTML

@dreispt dreispt Sep 14, 2016 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new dependency, right? Isn't LXML suitable for the job?

@dreispt

dreispt commented Sep 14, 2016

Copy link
Copy Markdown
Member

I'm not trying to push anything on you, and only as a reminder it would be desirable that help_popup and help_online eventually converge into a single module.

@bealdav
bealdav force-pushed the 8-help-popup-improvment branch from 2656626 to a09eefa Compare September 14, 2016 10:07
@bealdav

bealdav commented Sep 14, 2016 •

Copy link
Copy Markdown
Member Author

@dreispt why not, have you a plan in mind about functionalities that should stay or be extended and with which dependencies ?
cc @lmignon @Cedric-Pigeon

@bealdav
bealdav force-pushed the 8-help-popup-improvment branch from a09eefa to 2aa40c4 Compare September 14, 2016 10:18
@pedrobaeza pedrobaeza added this to the 8.0 milestone Sep 14, 2016
@bealdav
bealdav force-pushed the 8-help-popup-improvment branch 2 times, most recently from 650e751 to a850a7e Compare September 16, 2016 09:10
@bealdav
bealdav force-pushed the 8-help-popup-improvment branch from a850a7e to cf27d3b Compare September 16, 2016 09:41
@rafaelbn

rafaelbn commented Oct 4, 2016

Copy link
Copy Markdown
Member

Hi, I have been reviewing this module with @bealdav and it looks very simple and useful. About @dreispt comment #417 (comment), I agree that it's better not to depend in website as help_online do: https://github.com/OCA/web/blob/9.0/help_online/__openerp__.py#L30

This module is very interesting as potentially could solve the problem of Odoo with a full functional documentation made by end-users. In this moment the doc which end user write down is stored in Odoo database so if I do the doc I must export somehow to import for my other customers.

I will wait to have travis and runbot green to final review.

@bealdav
bealdav force-pushed the 8-help-popup-improvment branch from 02d3eb4 to b70da3e Compare October 4, 2016 09:03
@bealdav
bealdav force-pushed the 8-help-popup-improvment branch from b70da3e to 0e1d9c1 Compare October 4, 2016 10:18
Comment thread help_popup/tests/test_help.py Outdated
# partner_act.advanced_help,
# u'\nnew_content<help_base>toto</help_base>',
# "Partially updating of 'ir.model'.advanced_help is broken")
# # partner_act.remove_obsolete_help('base')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove or fix comment code?

try:
from bs4 import BeautifulSoup as BSHTML
except ImportError:
_logger.debug(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be at least a warning error, if we want to install this module I guess this import is required

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logger is for not installed module (oca guidelines)
There is raise in standard odoo installation module with 'external_dependencies' data in manifest.
No way to install if no dependency satisfied.

@gurneyalex gurneyalex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

github-actions Bot commented Dec 5, 2021

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 5, 2021
@github-actions github-actions Bot closed this Jan 9, 2022
@bealdav

bealdav commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

Help_popup revinvented OCA/knowledge#653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants